-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First or last x lines of text are shown even when there's no difference between the two compared texts. #50
Comments
As far as I'm aware most, if not all, renderers should produce either nothing or a string saying 'No differences found'. To which renderer are you referring? |
@DigiLive There shouldn't be any output. However, when I compare a.txt with a.txt in the example folder I get a difference. @@ -32,3 +32,3 @@
</body>
</html> I tired the orginal from chrisboulton/php-diff. There it isn't. I will track that tomorrow which commit caused that. |
v1.15 doesn't have that issue. It came with v1.16 now line 610 is if ($this->options['trimEqual'] || (!empty($group) && !(count($group) == 1 && $group[0][0] == 'equal'))) { was if (!empty($group) && !(count($group) == 1 && $group[0][0] == 'equal')) { |
Agreeing there's a bug... It's a combo of option However, HTML Side by Side Diff, HTML Inline Diff and HTML Unified Diff will produce output string |
Related to issue #24. |
@csalgadow We need your feedback for the renderer |
Thank you very much I will include your scipt in the online voting platform that I have at https://bitbucket.org/csalgadow/demokratian_votaciones/ Again, thank you very much for your quick response and for your work with php-diff |
You're very welcome. |
Hi
Thank you very much for this code that is very useful to me.
I would like to know if there is any method to know if there are no differences and thus not show anything or if it is possible to add it
The text was updated successfully, but these errors were encountered: