Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jquery once fix #48

Merged
merged 11 commits into from
May 17, 2023
Merged

Jquery once fix #48

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3aa5b7c
Removing jquery.once and adding once
aOelschlager May 4, 2023
c4c3fba
Fix once call
aOelschlager May 5, 2023
4af7277
Remove jquery
aOelschlager May 12, 2023
1fb4593
Calling once without jquery
aOelschlager May 12, 2023
fd7ab29
Change order
aOelschlager May 12, 2023
e4d3381
Revert back to making call with jquery library included
aOelschlager May 17, 2023
cca6434
Put that jquery back
aOelschlager May 17, 2023
5bf9dc3
Rework to fully use Drupal's `once()`.
adam-vessey May 17, 2023
00ed543
Some other uses of jQuery, so keep `$` around accordingly.
adam-vessey May 17, 2023
1835b9b
Looks like the `jQuery`/`$` usage should've been changed also.
adam-vessey May 17, 2023
e210573
Merge pull request #1 from adam-vessey/fix/once
aOelschlager May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/openseadragon_viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
Object.keys(settings.openseadragon).forEach(function(osdViewerId) {
// Use custom element #id if set.
base = '#' + osdViewerId;
$(base, context).once('openSeadragonViewer').each(function () {
once('openSeadragonViewer', $(base, context)).forEach(function () {
adam-vessey marked this conversation as resolved.
Show resolved Hide resolved
Drupal.openSeadragonViewer[base] = new Drupal.openSeadragonViewer(base, settings.openseadragon[osdViewerId]);
});
});
Expand Down Expand Up @@ -122,4 +122,4 @@
}

};
})(jQuery);
})(once);
3 changes: 1 addition & 2 deletions openseadragon.libraries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ init:
component:
css/openseadragon.css: {}
dependencies:
- core/jquery
- core/jquery.once
- core/once
- core/drupal
- core/drupalSettings
- openseadragon/openseadragon
Expand Down