Jquery once fix #48
Merged
Jquery once fix #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-vessey
reviewed
May 17, 2023
Rework to fully use Drupal's `once()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (link)
Islandora/documentation#2205
What does this Pull Request do?
Minor adjustment to the openseadragon javascript which connects the viewer to the underlying image resource
intended result of the PR will be and/or what problem it solves.
Prevents additional canvas elements from being shown in and below an OpenSeadragon viewer.
Technical details and possible side effects.
unknown
How should this be tested?
BEFORE this code is merged, it is important to find an islandora object with image media that will use the OpenSeadragon viewer -- which causes the doubled-canvas output. (See Islandora/documentation#2205). I have found that this happens when a larger resolution service file JPG is uploaded for a Service File media.
After the code has been merged, that same object from above should only display one canvas.
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers