Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate fix #818

Merged
merged 7 commits into from
Jan 13, 2021
Merged

Migrate fix #818

merged 7 commits into from
Jan 13, 2021

Conversation

elizoller
Copy link
Member

GitHub Issue: (Islandora/documentation#1741)

What does this Pull Request do?

Updates migration_tags to be an array

What's new?

  • Change to the migration configuration to make migration_tags an array
  • Update hook to update existing configuration
  • Removes messed up config that I accidentally added in the previous update hook 8004 with the name islandora__tags instead of islandora_tags

How should this be tested?

  • See migration_tags as a string
  • Pull in PR, run update
  • Verify migration_tags is an array now
  • Verify migrate_plus.migration.islandora__tags does not exist
  • Verify the presence of source:ids and not source:keys in islandora_tags

Interested parties

@Islandora/8-x-committers

seth-shaw-unlv
seth-shaw-unlv approved these changes Jan 13, 2021
View reviewed changes
Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-unlv seth-shaw-unlv merged commit 986a3d4 into Islandora:8.x-1.x Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seth-shaw-unlv seth-shaw-unlv seth-shaw-unlv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elizoller @seth-shaw-unlv