Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lock files for crayfish using newer chullo #61

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Apr 12, 2019

Fix Milliner tests relying on dead classes

GitHub Issue: n/a

Follow-up to Islandora/Crayfish-Commons#24 as Crayfish services all rely on islandora/crayfish-commons:dev-master.

As a follow on to this (say not on a Friday) we probably should cut a 0.1 release of Crayfish-Commons and change all the services here from islandora/crayfish-commons:dev-master to islandora/crayfish-commons:^0.1

What does this Pull Request do?

Updates lock files and fixes test fixtures.

What's new?

Really updates the crayfish-commons version which updates the chullo version.

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

I guess the best would be to pull this into a claw-playbook and see if it still works, but as only the tests still referred to the missing classes I think (🤞 ) we should be ok.

Interested parties

@Islandora-CLAW/committers

Fix Milliner tests relying on dead classes
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #61   +/-   ##
========================================
  Coverage      97.1%   97.1%           
  Complexity      140     140           
========================================
  Files             9       9           
  Lines           621     621           
========================================
  Hits            603     603           
  Misses           18      18
Impacted Files Coverage Δ Complexity Δ
Milliner/src/Service/MillinerService.php 100% <ø> (ø) 48 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab0da6...e370abb. Read the comment docs.

Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down your updated branch, ran composer install and composer test for each of the subcomponents Gemini, Homarus, Houdini, Hypercube, Milliner, and Recast. all tests passed.

@dannylamb
Copy link
Contributor

@whikloj Let's do this and I'll update #62

@dannylamb dannylamb merged commit be5bb9a into Islandora:master Apr 16, 2019
@whikloj whikloj deleted the fix-milliner-tests branch April 16, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants