Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: n/a
What does this Pull Request do?
Trying to integrate the GeminiClient into the Drupal islandora module I hit a block as Crayfish Commons requires Chullo version
^0.1.1
while Islandora already relys on Chullo version^0.2.0
Reading the composer version constraint docs (again) this means that Crayfish-Commons supports versions
>=0.1.1 <0.2.0
so the two are incompatibleThis PR updates the requirement to
^0.2
to match>=0.2 <1.0
What's new?
Once this is merged it will require a subsequent version tag for crayfish-commons and then a PR for Crayfish to update the lock files.
As well there is a question whether islandora should be using
^0.2.0
or^0.2
. Minor versions should not be backwards breaking so perhaps supporting all changes until we hit a1.0
release (which should probably coincide with the release of Islandora 8)How should this be tested?
Not even sure. The differences in 0.1.1 and 0.2.0 are in the merging (mostly) of 2 classes into one so I don't think anything should be affected.
Interested parties
@Islandora-CLAW/committers