Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chullo dependency #24

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Apr 12, 2019

GitHub Issue: n/a

What does this Pull Request do?

Trying to integrate the GeminiClient into the Drupal islandora module I hit a block as Crayfish Commons requires Chullo version ^0.1.1 while Islandora already relys on Chullo version ^0.2.0

Reading the composer version constraint docs (again) this means that Crayfish-Commons supports versions >=0.1.1 <0.2.0 so the two are incompatible

This PR updates the requirement to ^0.2 to match >=0.2 <1.0

What's new?

Once this is merged it will require a subsequent version tag for crayfish-commons and then a PR for Crayfish to update the lock files.

As well there is a question whether islandora should be using ^0.2.0 or ^0.2. Minor versions should not be backwards breaking so perhaps supporting all changes until we hit a 1.0 release (which should probably coincide with the release of Islandora 8)

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

Not even sure. The differences in 0.1.1 and 0.2.0 are in the merging (mostly) of 2 classes into one so I don't think anything should be affected.

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage     92.53%   92.53%           
  Complexity      136      136           
=========================================
  Files             9        9           
  Lines           415      415           
=========================================
  Hits            384      384           
  Misses           31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e361bd...9a5f923. Read the comment docs.

Copy link
Contributor

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathangreen jonathangreen merged commit 19a03eb into Islandora:master Apr 12, 2019
@whikloj whikloj deleted the update-chullo-version branch April 12, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants