Remove unnecessary reverse proxy. #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2022
|
We're continuing to see funky timeouts and are starting to suspect that some of them may get stuck in these unnecessary proxies. I'll try to spring some of Danny's time to test this... we agree it is an important step forward. |
nigelgbanks
force-pushed
the
issue-186-remove-unnecessary-reverse-proxy
branch
from
ee2e639 to
18afcca
Compare
|
Islandora-Devops/isle-buildkit#187 got merged , then https://github.com/Islandora-Devops/isle-dc/pull/244/files got merged which pulled in the new build-kit changes (which required this to be merged) so now the develop branch is borked. It would be good if this could get in asap. |
|
Looks good to me. I've been slapping these change on all our docker-compose.ymls over at BD. |
dannylamb
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires Islandora-Devops/isle-buildkit#187 to be merged first after that is done I'll do a release and this can then be merged.