-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for composition implementation and message package name change #1415
Conversation
Update librealsense2 version to 2.38.1
Design and interface modifications
…e-ros into IntelRealSense-eloquent
|
ping @doronhi |
ping @RealSenseSupport |
Sorry for so far failing to check your PR. It includes a couple of topics and I won't be able to merge it as a whole. |
Thank you for your reply. Let me know if you find anything unclear while working on it. Jaehyun |
Regarding the realsense2_description, if I understand correctly, it is not working yet. In the file view_d435_model.launch.py The keyword "executable" needs to be replaced with "node_executable" and there is no parsing of the urdf.xacro file. I'll skip the description package as I already have #1429 . If you manage to find the time to make some more PRs in the future it would help a lot if it separated into several PRs, each with a single scheme. |
Thank you. OK I will keep that in mind next time. Have a great day. Jaehyun |
@RealSenseSupport @doronhi
As I mentioned in this issue thread, I did the followings.
As I mentioned in the issue thread, please redirect this PR to your new branch, desirably 'ros2' branch, and please keep your original code in the current 'eloquent' branch (i suggest you change the name to 'eloquent-devel') since you already binary-released it this month.
Let me know if you have any comments on it,
Ryan