Avoid using ExperimentalTime API

[pubiqq]

Koin breaks down after every minor update of Kotlin because of the use of the experimental time api in logging, it's just ridiculous.

Here is a fix that replaces the use of experimental functions with the use of stable ones.

Prevents the recurrence of issues like:

• java.lang.NoSuchMethodError with kotlin 1.6 #1242
• androidLogger() doesn't work with Kotlin 1.6 #1216
• Does not support Kotlin 1.6.0 #1188
• java.lang.NoSuchMethodError: No virtual method elapsedNow-UwyO8pc()D in class Lkotlin/time/TimeMark #1076
• Koin noSuchMethodError exception #917
• After updating Koin 2.1.6 version I Got crash like. java.lang.NoSuchMethodError: No virtual method elapsedNow()D in class Lkotlin/time/TimeMark; or its super classes (declaration of 'kotlin.time.TimeMark' appears .... #871
• [Crash] Koin Logger Measure and Kotlin EAP 1.4-M3 #847

[arnaudgiuliani]

I agree with you, this time API is breaking updates since too much time. For 3.2 we plan to rework this also, to avoid such breaking.

Let me check how our solution is going with yours.

[pubiqq]

Sure. Feel free to ask me if you have any questions about the changes made.

[arnaudgiuliani]

I've ported some of your code (JS/Native Nanoseconds util) - 0a10adc

It works better now 💪

[arnaudgiuliani]

I close this, as I believe I have everything we need. Your feedback is welcome @pubiqq

[pubiqq]

Your feedback is welcome

Well...

• self is not defined in Node.js, so your change doesn't work properly.
• measureDuration and measureTime are the same thing, just one function is marked with opt-in @KoinInternalApi, and the other is not, something obviously superfluous.
• Pair measureDurationForResult/measureTimedValue has the same problem + measureDurationForResult does redundant actions (destructures the result value and creates the same one).
• performance.now() is available in WebView for Android SDK 19 and above, but for koin-android you declare support for Android SDK 14 and above. It may seem it's about two different things, but since you declare support for Android SDK 14, you admit that such devices exist, so you need to ensure that the library works on them as well.
• File naming leaves much to be desired, like KoinPlatformTimeTools class (ok, assume) inside PlatformTimeToolsJVM.kt file (you are already inside the jvm target, you don't need to mention it again with a suffix) inside mp folder (in short, it's weird to have a "multiplatform" folder inside a folder associated with a specific platform) inside jvm target.
• The code is not formatted everywhere, use the "Reformat Code" command or the appropriate keyboard shortcut (for Android Studio: Ctrl + Alt + L on Windows and Linux, ⌥⌘L on Mac). If you constantly forget about it, or you don't want to do it manually, you can configure the environment to do this before commit (for Android Studio: "File" -> "Settings" -> "Version Control" -> "Commit" -> group "Before Commit" -> select the necessary actions: reformat, cleanup and so on). Also, you can delegate this work to your CI platform (there is no specific advice here, it all depends on the CI platform and your development process).

To be honest, I would still recommend using my PR. 🙃

[arnaudgiuliani]

My bad. I took all the code on JS side:

https://github.com/InsertKoinIO/koin/blob/3.2.x/core/koin-core/src/jsMain/kotlin/org/koin/mp/PlatformTimeTools.kt
https://github.com/InsertKoinIO/koin/blob/3.2.x/core/koin-core/src/jsMain/kotlin/org/koin/core/time/TimeSource.kt