Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.lang.NoSuchMethodError: No virtual method elapsedNow-UwyO8pc()D in class Lkotlin/time/TimeMark #1076

Closed
ligi opened this issue Apr 27, 2021 · 19 comments
Labels
core important 🔥 status:checking currently in analysis - discussion or need more detailed specs type:issue
Milestone

Comments

@ligi
Copy link
Contributor

ligi commented Apr 27, 2021

Describe the bug

After updating to Kotlin 1.5.0 I am getting this runtime error:

04-27 15:37:54.756  6429  6429 E AndroidRuntime: java.lang.NoSuchMethodError: No virtual method elapsedNow-UwyO8pc()D in class Lkotlin/time/TimeMark; or its super classes (declaration of 'kotlin.time.TimeMark' appears in /data/app/org.walleth-rBcMmS3wfGt-FnuS1dhI1g==/base.apk)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at org.koin.core.time.MeasureKt.measureDuration(Measure.kt:63)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at org.koin.core.KoinApplication.modules(KoinApplication.kt:63)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at org.walleth.App$onCreate$1.invoke(App.kt:142)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at org.walleth.App$onCreate$1.invoke(App.kt:139)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at org.koin.core.context.GlobalContext.startKoin(GlobalContext.kt:65)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at org.koin.core.context.DefaultContextExtKt.startKoin(DefaultContextExt.kt:31)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at org.walleth.App.onCreate(App.kt:139)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1182)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6460)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at android.app.ActivityThread.access$1300(ActivityThread.java:219)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1859)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:107)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:214)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:7356)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
04-27 15:37:54.756  6429  6429 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

happens with koin 3.0.1

@Makzimalist
Copy link

I have the same issue, but without updating to Koltin 1.5.0, but with update org.jetbrains.kotlinx:kotlinx-serialization-core to 1.2.0
koin = "3.0.1" kotlin = "1.4.32" kotlinxSerialization = "1.2.0"

@trashkalmar
Copy link
Contributor

As a temp workaround you should set your KoinApplication.logger() to Level.ERROR or Level.NONE.
Or just do not configure logger at all.

@arnaudgiuliani arnaudgiuliani added this to the 3.0.2 milestone May 3, 2021
@arnaudgiuliani arnaudgiuliani added core status:checking currently in analysis - discussion or need more detailed specs type:issue labels May 3, 2021
@almozavr
Copy link

almozavr commented May 5, 2021

I believe this is critical as more and more people will jump in 1.5.0 kotlin

@guillaume-tgl
Copy link

guillaume-tgl commented May 6, 2021

Is there any workaround when I'm not using Koin directly in my Android app but when it's one of my dependencies that uses Koin? It seems like the default log level is set to Info for Android applications.

@sipersso
Copy link

sipersso commented May 8, 2021

I am also using a dependency that has Koin and this isn't the first time this happens unfortunately. Right now this issue makes my app crash for all users reaching out for support :/

liujoshua added a commit to liujoshua/AssessmentModel-KotlinNative that referenced this issue May 12, 2021
@digrec
Copy link

digrec commented May 17, 2021

Can a fix for this also be added to upcoming Koin 2.3 milestone?

We are still using Koin v2 in app. While we could update app to v3 soon (already tried), but we also use a 3rd party dependency that still uses Koin v2 - and this of course fails to build due to duplicate Koin classes from v2 and v3 packages.

@arnaudgiuliani
Copy link
Member

arnaudgiuliani commented May 17, 2021

yep, this is the same source problem with Time API from Kotlin that remains inconsistent :/

We need to recompile Koin with Kotlin 1.5.0

@arnaudgiuliani
Copy link
Member

Can a fix for this also be added to upcoming Koin 2.3 milestone?

We are still using Koin v2 in app. While we could update app to v3 soon (already tried), but we also use a 3rd party dependency that still uses Koin v2 - and this of course fails to build due to duplicate Koin classes from v2 and v3 packages.

Yep a 2.2.3 will appear soonly

@digrec
Copy link

digrec commented May 17, 2021

Can a fix for this also be added to upcoming Koin 2.3 milestone?
We are still using Koin v2 in app. While we could update app to v3 soon (already tried), but we also use a 3rd party dependency that still uses Koin v2 - and this of course fails to build due to duplicate Koin classes from v2 and v3 packages.

Yep a 2.2.3 will appear soonly

Great! Thank you!

@arnaudgiuliani
Copy link
Member

Deployment done for 3.0.2 & 2.2.3 🎉

@arkon
Copy link

arkon commented May 18, 2021

Is there supposed to be new versions of all modules? io.insert-koin:koin-androidx-compose:3.0.2 doesn't seem to exist.

@arnaudgiuliani
Copy link
Member

compose can't be compiled with Kotlin 1.5 for now. We need to wait for a next update.

@digrec
Copy link

digrec commented May 19, 2021

Deployment done for 3.0.2 & 2.2.3 🎉

Where can I get org.koin:koin-android:2.2.3?

Maven Central only has the new io.insert-koin:koin-android:2.2.3 which conflicts with 3rd party lib that depends on org.koin:koin-android:2.2.2 from JCenter:

Duplicate class org.koin.android.BuildConfig found in modules jetified-koin-android-2.2.2-runtime (org.koin:koin-android:2.2.2) and jetified-koin-android-2.2.3-runtime (io.insert-koin:koin-android:2.2.3) ...

Any ideas how to go about this? Or the only option is to wait for 3rd party lib to update to io.insert-koin:koin-android:2.2.3?

@ligi
Copy link
Contributor Author

ligi commented May 19, 2021

Thanks - I can confirm the fix works!

@digrec don't think this will be possible - jcenter is discontinued and does not accept new artefacts - you will need to push your 3rd party lib to switch.

@digrec
Copy link

digrec commented May 19, 2021

@ligi I'm aware of JCenter EOL and read only mode. I'll wait then, thanks!

@arnaudgiuliani
Copy link
Member

@digrec Can you reopen a new issue?

@digrec
Copy link

digrec commented May 20, 2021

@digrec Can you reopen a new issue?

The 3rd party lib did migrate to io.insert-koin:koin-android in the mean time and I was also able to upgrade my app to v3 today. All good now, thanks!

@arnaudgiuliani
Copy link
Member

yes, migrate to maven central artifacts. This is the sure way 👍

luk1337 added a commit to luk1337/anitrend-v2 that referenced this issue May 25, 2021
wax911 pushed a commit to AniTrend/anitrend-v2 that referenced this issue May 26, 2021
soulskill added a commit to endiosGmbH/Android-Config that referenced this issue Jun 1, 2021
@sherden
Copy link

sherden commented Jun 16, 2021

Maven Central only has the new io.insert-koin:koin-android:2.2.3 which conflicts with 3rd party lib that depends on org.koin:koin-android:2.2.2 from JCenter:

Duplicate class org.koin.android.BuildConfig found in modules jetified-koin-android-2.2.2-runtime (org.koin:koin-android:2.2.2) and jetified-koin-android-2.2.3-runtime (io.insert-koin:koin-android:2.2.3) ...

Any ideas how to go about this? Or the only option is to wait for 3rd party lib to update to io.insert-koin:koin-android:2.2.3?

For those facing with this problem, you can use dependencySubstitution in gradle (you can use any compatible version):

configurations.all {
    resolutionStrategy {
        dependencySubstitution {
            substitute module('org.koin:koin-android:2.2.2') using module("io.insert-koin:koin-android:2.2.3")
        }
    }
}

soulskill added a commit to endiosGmbH/Android-Config that referenced this issue Jun 30, 2021
wax911 added a commit to AniTrend/anitrend-v2 that referenced this issue Dec 18, 2021
* Bump androidx.compose.* [1.0.0-beta03 -> 1.0.0-beta05]

See:
- androidx.compose.compiler:compiler [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.0.0-beta05
 - androidx.compose.foundation:foundation [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-foundation#1.0.0-beta05
 - androidx.compose.foundation:foundation-layout [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-foundation#1.0.0-beta05
 - androidx.compose.material:material [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-material#1.0.0-beta05
 - androidx.compose.material:material-icons-core [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-material#1.0.0-beta05
 - androidx.compose.material:material-icons-extended [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-material#1.0.0-beta05
 - androidx.compose.runtime:runtime [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-runtime#1.0.0-beta05
 - androidx.compose.runtime:runtime-livedata [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-runtime#1.0.0-beta05
 - androidx.compose.ui:ui [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-ui#1.0.0-beta05
 - androidx.compose.ui:ui-test [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-ui#1.0.0-beta05
 - androidx.compose.ui:ui-tooling [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-ui#1.0.0-beta05
 - androidx.compose.ui:ui-viewbinding [1.0.0-beta03 -> 1.0.0-beta05]
     https://developer.android.com/jetpack/androidx/releases/compose-ui#1.0.0-beta05

* Bump constraintlayout-compose [1.0.0-alpha05 -> 1.0.0-alpha06]

* Bump androidx:constraintlayout [2.1.0-beta01 -> 2.1.0-beta02]

* Bump androidx.fragment:fragment [1.3.2 -> 1.3.3]

See: https://developer.android.com/jetpack/androidx/releases/fragment#1.3.3

* Bump lifecycle-viewmodel-compose [1.0.0-alpha02 -> 1.0.0-alpha04]

See:  https://developer.android.com/jetpack/androidx/releases/lifecycle#1.0.0-alpha04

* Bump androidx.recyclerview:recyclerview [1.2.0-rc01 -> 1.2.0]

See: https://developer.android.com/jetpack/androidx/releases/recyclerview#1.2.0

* Bump androidx.work:work-* [2.7.0-alpha02 -> 2.7.0-alpha03]

See: https://developer.android.com/jetpack/androidx/releases/work#2.7.0-alpha03

* Bump com.airbnb.android:lottie [3.6.1 -> 3.7.0]

See: https://github.com/airbnb/lottie-android

* Bump com.airbnb.android:paris [1.7.2 -> 1.7.3]

See: https://github.com/airbnb/paris

* Update com.github.Jay-Goo:RangeSeekBar [v3.0.0 -> 3.0.0]

* Bump anitrend:support-markdown [0.12.0-alpha01 -> 0.12.0-alpha02]

* Bump com.google.accompanist:accompanist-appcompat-* [0.7.0 -> 0.8.1]

See: https://github.com/google/accompanist/

* Bump material:compose-theme-adapter [1.0.0-beta03 -> 1.0.0-beta05]

See: https://github.com/material-components/material-components-android-compose-theme-adapter/

* Bump google.android.material:material [1.4.0-alpha01 -> 1.4.0-alpha02]

See: https://github.com/material-components/material-components-android

* Bump com.google.firebase:firebase-analytics-ktx [18.0.2 -> 18.0.3]

* Bump com.jakewharton.threetenabp:threetenabp [1.3.0 -> 1.3.1]

See: https://github.com/JakeWharton/ThreeTenABP/

* Bump io.coil-kt:* [1.1.1 -> 1.2.1]

See: https://github.com/coil-kt/coil

* Bump org.jetbrains.kotlin:* [1.4.31 -> 1.5.0]

See: https://blog.jetbrains.com/kotlin/2021/05/kotlin-1-5-0-released/#stable-language-features

* Bump org.jetbrains.kotlinx:kotlinx-* [1.4.3 -> 1.5.0-RC]

See: https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md

* Bump org.jetbrains.kotlinx:kotlinx-serialization-json [1.1.0 -> 1.2.0]

See: https://github.com/Kotlin/kotlinx.serialization

* Remove deprecated IR backend option for kotlin compiler

* Revert "Bump androidx.work:work-* [2.7.0-alpha02 -> 2.7.0-alpha03]"

This reverts commit 3b369e4.

Since `2.7.0-alpha03` is only compatible with the Android 12 Developer Preview 3 SDK.

* Bump build tools version 7.0.0-alpha14 -> 7.0.0-alpha15

* Bump gradle wrapper [7.0 -> 7.0.2]

* Bump multiple dependencies

The following dependencies have been updated to the latest milestone versions:
 - androidx.compose.compiler:compiler [1.0.0-beta05 -> 1.0.0-beta06]
     https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.0.0-beta06
 - androidx.compose.foundation [1.0.0-beta05 -> 1.0.0-beta06]
     https://developer.android.com/jetpack/androidx/releases/compose-foundation#1.0.0-beta06
 - androidx.compose.material [1.0.0-beta05 -> 1.0.0-beta06]
     https://developer.android.com/jetpack/androidx/releases/compose-material#1.0.0-beta06
 - androidx.compose.runtime [1.0.0-beta05 -> 1.0.0-beta06]
     https://developer.android.com/jetpack/androidx/releases/compose-runtime#1.0.0-beta06
 - androidx.compose.ui [1.0.0-beta05 -> 1.0.0-beta06]
     https://developer.android.com/jetpack/androidx/releases/compose-ui#1.0.0-beta06
 - androidx.room:room-* [2.2.6 -> 2.4.0-alpha02]
     https://developer.android.com/jetpack/androidx/releases/room#2.4.0-alpha02
 - app.cash.turbine:turbine [0.4.1 -> 0.5.0]
     https://github.com/cashapp/turbine/
 - com.dropbox.mobile.store:store4 [4.0.0 -> 4.0.1]
     https://github.com/dropbox/Store/
 - com.google.accompanist:accompanist-* [0.8.1 -> 0.9.1]
     https://github.com/google/accompanist/
 - com.google.android.material:compose-theme-adapter [1.0.0-beta05 -> 1.0.0-beta06]
     https://github.com/material-components/material-components-android-compose-theme-adapter/
 - com.google.android.material:material [1.4.0-alpha02 -> 1.4.0-beta01]
     https://github.com/material-components/material-components-android
 - com.google.firebase:firebase-analytics-ktx [18.0.3 -> 19.0.0]
 - com.google.firebase:firebase-crashlytics [17.4.1 -> 18.0.0]
 - com.google.firebase:firebase-crashlytics-gradle [2.5.2 -> 2.6.1]
 - com.google.gms:google-services [4.3.5 -> 4.3.8]
 - org.jetbrains.kotlinx:kotlinx-coroutines-* [1.5.0-RC -> 1.5.0]
     https://github.com/Kotlin/kotlinx.coroutines
 - org.jetbrains.kotlinx:kotlinx-serialization-json [1.2.0 -> 1.2.1]
     https://github.com/Kotlin/kotlinx.serialization

* Replace deprecated options

* Remove glide dependencies devoting to coil all the way

* Add media list navigation targets and workers

* Move recommendations into model sub package

* Remove invalid character on room dependency

* Replace setIsDefault with isDefault

* Add content templates for media-list feature

* Revert kotlin and coroutine dependency updates to retain compatibility

For compatibility with compose

* Update decorator to use custom values instead of resource dimens

* Suppress deprecated internals of transaction as deprecated

* Bump support-arch version from 1.3.0-rc02 to 1.3.0-rc05

* Clean up buildSrc and update candidate version

* Update list content contract

See commit: ba0db10

* Set filter sheet height to display height and enable scrolling

* Cleanup rating widget background style

* Add media progress controller test

* Remove off screen page limit

Does not seem to work in this case

* Replace range seek bar with material range slider

Also replaces scroll view with nested scroll view

* Rename media list content view model

* Remove user entity from media list entity view

* Add rankings and external links to media model

* Include rankings and links into converters, domain and entity view

* Refactor link and rank mappers for easier embed delegation

* Add link and rank embeds on all media mappers

* Drop deferred foreign keys which led to a lot of transaction errors

Surprisingly enabling deferred foreign key validation leads to a lot of `Cannot start transaction within a transaction` errors

* Expose fragment item tag

For easier tag overriding

* Explicit named parameters for discover filter sheet

* Refactor media list router params

* Add navigation targets for anime and manga lists

* Add transient custom list name parameter for querying by customlist name

* Update media list feature finalising first draft

* Update schema

* Add missing field for user extended model

* Update data module

Removes deferred foreign keys.

see commit: c647f6f

* Remove advanced scores and custom lists from media list entity

* Update converts and type converters post removal of columns

See commit: 52e8426

* Bump database schema version and add migration

* Add transaction annotation to media by id flow

* Bump candidate version from 37 to 38

* Bump support-arch from 1.3.0-rc05 to 1.3.0-rc06

* Default clear data on refresh to false on preferences

See commit: bffb6d2

* Remove database views for tag and genre

* Replace database views with relation entities for tag and genre

See commit: 4aa3000

* Re-add transaction annotation to embed/relation dao results

* Update deprecated constructor for coil image decoder

* Add default message to state configuration

* Source file format fixes

* Remove fdroid build flavour and keep github flavour as alternative

* Remove KoinExperimentalApi compiler opt-in

* Add new dependency configuration types for build flavours

Allows targeted inclusion of dependency based on build flavour

* Apply firebase dependencies on google build flavour only

* Add new android and androidLibrary components project extensions

* Improve error handling and log verbosity around it

* Refactor base screen name from Anitrend* to AniTrend

* Add feed and suggestion modules

* Update notification and review templates

* Move in memory database to test module

* Bump build tools version [7.0.0-alpha15 -> 7.0.0-beta02]

* Remove deprecated signing option

See commit: 7e36780

* Re-arrange media list status

* Set gradle jvm to use android studio bundled JDK

* Remove filter operator for non-null flow on interaction flow

* Update XmlUtil source URL and drop accompanistSnapshot while at it (#72)

* Trigger test workflow on pull request and push

* Block UI state from being updated when view model value is not null

This is to guard against showing an error message for cached entries when a network failure occurs

* Initial implementation of build flavour specific dependencies 

Adds analytics tree for both google and github flavours

* Update Koin to 2.2.3 and disable Koin.AndroidX.compose for time being (#73)

Fixes crashes with Kotlin 1.5.0.
See: InsertKoinIO/koin#1076

* Revert "Update Koin to 2.2.3 and disable Koin.AndroidX.compose for time being (#73)"

This reverts commit e27fee2.

* Explicitly add androidx.collection dependency

* Update jarRepositories.xml

* Add date time kotlinx dependency representative

* Add interceptor to default and graphql controllers

Adds the ability to intercept network response for inspection are mutation purposes

* Add new extension to update SupportPagingHelper internals

Adds the ability to utilise `IPageModel` to get paging information, in so helping us avoid unnecessary request queries when the next page may not contain any results

* Remove `loadBefore` impl for paging items that do not benefit from it

Minor improvement that disables loading in reverse `currentPage - 1` for sources that do not benefit from it.

* Update cache request paging rules for end of paging cases

Prevents running the next page request when paging has no further queries ahead (typically we'd only know that we're at the end of paging when no additional results are returned)

* Rename incorrectly named variable in cache store policy

Minor refactor for the sake of readability

* Combine tag connection entity indices

* Allow AniTrendListContent to append a default header/footer adapter 

Allows the list content fragment to display a default adapter item when load state returns success

* Temporarily disable KoinLogger from logging

Regression for koin logger leading to crashes with the method not found error for kotlinx.time

* Revert migration to multi-process work manager

* Improve default error message handling case

* Enforce kotlin library version for conflict resolution

* Bump com.android.tools.build:gradle [7.0.0-beta02 -> 7.0.0-beta04]

* Rename UpdateMediaListEntries to SaveMediaListEntries

* Rename SaveMediaListItem to SaveMediaListEntry

* Add id and scoreFormat to save medialist entry mutation

* Return MediaListCore from save media list entry

Fixes an issue were the API would return an http 500 error when media is included in the mutation body.
> `MediaList.Core` excludes `Media` which has no added benefit in this scenario

* Default media list params in domain to nullable

Ensures that all other fields that had predefined values are set to null, this may avoid unintentional overriding of a users media list state

* Update medial list task router params

See commits: 41723f3 & 8ecea3c

* Update media list workers params

* Update media list entities

- `IMediaList.status` is no longer null
-  `MediaListProgress` provides `repeated` as an abstraction

* Add new media presenter for common media and update progress controller

* Add new date helper as a derivative of AbstractSupportDateHelper

* Update equality check for media carousel

* Use class default equality checker for media carousel list differ

See commit: 68550bf

* Expand on media equality check to include underlying media list

* Remove unused imports

* Add gson for de/serializing complex worker input data

Works around the limitation of map parameter with work manager data which only accepts primitive types

* Correct fuzzy date offset on creation

* Move back press callback for sheets to base sheet class

* Restructure image request model and move extension out of model package

* Add media list editor navigation route

* Update common media controller signature and interaction flow

* Include score format and media id in media list param

* Update media list schema and repository and interactor return types

* Update references to image request extension

See commit: 359acc1

* Remove redundant package qualifier

* Add new ok and authentication prompt strings

* Bump anitrend:arch [1.3.0-rc06 -> 1.3.0-rc07]

* Add feature media list editor

* Add common-medialist-ui module

* Bump gradle build tools from 7.0.0-beta04 to 7.0.0

* Temporarily used fork of material components

Adds recently merged PR for showing status of bottom app bar e.t.c this is a temporary change and will be reverted in the future

* Register common media ui as library item

* Restructure mocck dependency definition

* Add markwon editor sub module

* Remove mocck version from shared versions

* Update import references for deprecated gradle

* Remove deprecated media list tasks

* Work around casting unchecked exception on span inspector

Performs value check and converts only if the string is a digit/number

* Remove enforced view pager offscreen page limit

* Update recycler extension signature

Allows null recycler view pool to be supplied

* Add review sample data

* Add common editor ui wiget and initializer and dependencies

* Simplify bottom sheet creation

* Add additional override for fragment factory with context

* Remove type restriction on emoji manager and use bind instead

* Remove unused fallback image url

* Remove redundant null check for exhausted `when`

* Remove not null marker for paged reviews

* Minor media list query corrections and additions

* Add bottom sheet reveal on back pressed

* Add date helper test case

* Refactor category class signature

* Refactor view pager bottom scrolling workaround into extension

* Add additional date converters for fuzzy date

* Update view extensions and add context extensions

* Temporarily disable dubbed shows being displayed in feeds

This is just a QOL improvement as there is not guaranteed way to only show dubs for a specific language, instead we're just going to hide all dubs by default and only keep subs

* Update schema.graphql with respective models and entities

* Update user model, data and domain entities to cater for new types

* Bump com.android.tools.build:gradle [7.0.0 -> 7.0.1]

* Remove review id from review paged query

* Re-add transaction annotation of `upsert` 

See commit: 49ccf9b

> Thanks Moka

* Index configuration for entities refactoring

* Add new cache request types

* Add new styles for material date picker, popup theme and spinner

* Update database schema

* Cleanup unused resources

* Add new media sources for version 3

* Add new media notification types

Adds media change, deletion and merge notification fragments and implements them in queries

* Update schema.graphql

* Bump com.android.tools.build:gradle [7.0.1 -> 7.0.2]

* fixup! Update schema.graphql with respective models and entities (#74)

* Add review data and domain components

* Change review type for paged graphql response

* Register review dao contract with platform database

* Add review rating type converters

* Register review entity with platform database

* Update database schema

Adds `ReviewEntity` database schema information

* Remove .travis.yml

* Add common review-ui

* Add bottom sheet view pager for `ViewPager` support

* Downgrade gradle version from 7.1 to 7.0.2

This is done to avoid IDE feature support mismatch, this shouldn't typically be an issue but better to avoid potential problems if we can

* Update build.gradle.kts

* Update Sorting.kt

Correct deprecated `Parcelize` import

* Update navigation extensions

Adds new extension function to serialise work manager parameters and helper for crating unique one time requests

* Bump com.github.anitrend.support-arch [1.3.0-rc07 -> 1.3.0]

* Bump com.github.anitrend:retrofit-graphql [0.11.0-beta2 -> 0.11.0-beta3]

* Bump com.github.wax911:material-components-android

* Bump org.jetbrains.dokka:dokka-gradle-plugin [1.4.30 -> 1.4.32]

* Bump io.insert-koin [2.2.1 -> 2.2.3]

* Bump timber [4.7.1 -> 5.0.1]

* Remove deprecated `BaseVariantOutput`

* Remove non-existing compose koin dependency

* Update theme module list name

Changes spelling from singular to plural for consistency

* Clean up android-core module

Adds documentation and removes unused resources

* Refactor task parameters and common presenter view intent implementation

Applies multiple refactor tasks including work manager parameter construction, documentation updates and extracting out duplicated common code

* Add review task workers

Adds workers for common review tasks including `save`, `vote` and `delete`

* Add review vote widgets

* Integrate review modules into application

* Update NavitgationTargets.kt

Removes unused code and add missing imports for review domain objects

* Update MainScreen.kt

Change fragment item router name

* Add ic_edit.xml drawable resource

* Add presenter helper for checking if user is current user

* Add new android-deeplink module

* Update AniTrendScreen.kt

Replaces `activityScope` with `activityRetainedScope`

* Allow media lists and users to be queries by username

Adds additional `username` fields on params and response bodies for to allow user to be queried by `userName` or `id`

* Add git project extensions

* Refactor version code formatting

* Restrict viewmodel state from being observed when it is not set

Avoids observing a potentially null observable

* Refactor feature-auth AndroidManifest.xml

* Add parameters to navigation drawer router

* Use navigation drawer router params in screenstate

* Add new deep link host targets

* Add new navigation targets and update params

* Update deep link module with intent filters and routes

Adds routes for handling web and app URIs

Co-authored-by: luk1337 <[email protected]>
syoung-smallwisdom pushed a commit to BiAffectBridge/AssessmentModel-Kotlin that referenced this issue Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core important 🔥 status:checking currently in analysis - discussion or need more detailed specs type:issue
Projects
None yet
Development

No branches or pull requests

10 participants