-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: External links download all progres UI #1375
Open
adrien-coye
wants to merge
4
commits into
externalLinks-famousLastFivePercent
Choose a base branch
from
externalLinks-downloadAll-progres
base: externalLinks-famousLastFivePercent
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
74eb232
feat: Loading ui on public share download all
adrien-coye e73173e
feat: Cancel a download all action from UITabBarItem
adrien-coye d3a9775
refactor: Simpler UITapGestureRecognizer passthrew
adrien-coye 4ff6630
chore: Perhaps a more consensual naming
adrien-coye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,11 +53,26 @@ final class FileListBarButton: UIBarButtonItem { | |
let image = KDriveResourcesAsset.download.image | ||
self.init(image: image, style: .plain, target: target, action: action) | ||
accessibilityLabel = KDriveResourcesStrings.Localizable.buttonDownload | ||
case .downloadingAll: | ||
self.init(title: nil, style: .plain, target: target, action: action) | ||
|
||
let activityView = UIActivityIndicatorView(style: .medium) | ||
activityView.startAnimating() | ||
|
||
let tapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(cancelDownloadPressed)) | ||
activityView.addGestureRecognizer(tapGestureRecognizer) | ||
|
||
customView = activityView | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having an action matching our pattern of calling on a UITabBarItem with a custom view was not trivial. |
||
case .addToMyDrive: | ||
let image = KDriveResourcesAsset.drive.image | ||
self.init(image: image, style: .plain, target: target, action: action) | ||
accessibilityLabel = KDriveResourcesStrings.Localizable.buttonAddToKDrive | ||
} | ||
self.type = type | ||
} | ||
|
||
@objc private func cancelDownloadPressed() { | ||
guard let targetObject = target as? NSObject, let action else { return } | ||
targetObject.perform(action, with: self) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it is cleaner to change the configuration and refresh than write directly to the ViewModel state.