feat: External links download all progres UI #1375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
adrien-coye
commented
Jan 9, 2025
| private func downloadAll(sender: Any?, publicShareProxy: PublicShareProxy) { | ||
| let button = sender as? UIButton | ||
| button?.isEnabled = false | ||
| configuration.rightBarButtons = [.downloadingAll] |
There was a problem hiding this comment.
IMO it is cleaner to change the configuration and refresh than write directly to the ViewModel state.
| let tapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(cancelDownloadPressed)) | ||
| activityView.addGestureRecognizer(tapGestureRecognizer) | ||
|
|
||
| customView = activityView |
There was a problem hiding this comment.
Having an action matching our pattern of calling on a UITabBarItem with a custom view was not trivial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display an activity indicator while the download proceeds.
Can cancel a download all action with a tap.
root pr #1349