Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(DownloadArchiveOperation): Split code related to publicShare #1368

Merged

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Dec 30, 2024

Root PR : #1311

@adrien-coye adrien-coye requested a review from lebojo December 30, 2024 10:39
@adrien-coye adrien-coye changed the base branch from externalLinks-famousLastFivePercent to externalLinks-multiSelect December 30, 2024 10:41
@adrien-coye adrien-coye mentioned this pull request Dec 30, 2024
2 tasks
@adrien-coye adrien-coye force-pushed the refactor-download-archive-operation branch from 9362efc to 277b933 Compare December 30, 2024 10:49
@adrien-coye adrien-coye force-pushed the refactor-download-archive-operation branch from 277b933 to d96e98d Compare December 30, 2024 10:50
@adrien-coye adrien-coye changed the title refactor: Download archive operation refactor(DownloadArchiveOperation): Split code related to publicShare Dec 30, 2024
@adrien-coye
Copy link
Contributor Author

I did a test with a public share and a standard account, works fine.

@adrien-coye adrien-coye marked this pull request as ready for review December 30, 2024 10:57
@adrien-coye adrien-coye merged commit 17109b6 into externalLinks-multiSelect Dec 30, 2024
5 checks passed
@adrien-coye adrien-coye deleted the refactor-download-archive-operation branch December 30, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants