feat: Multiselect behaviour #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2024
adrien-coye
force-pushed
the
externalLinks-downloadFiles
branch
from
4061345 to
6c99ba0
Compare
adrien-coye
force-pushed
the
externalLinks-multiSelect
branch
from
9651af4 to
0fe23be
Compare
Base automatically changed from
externalLinks-downloadFiles
to
feature-externalLinks
October 23, 2024 12:00
adrien-coye
commented
Nov 27, 2024
adrien-coye
force-pushed
the
externalLinks-multiSelect
branch
from
8c33c37 to
7054054
Compare
adrien-coye
commented
Nov 27, 2024
kDrive/UI/Controller/Files/MultipleSelectionFloatingPanelViewController.swift
Outdated
Show resolved
Hide resolved
adrien-coye
force-pushed
the
externalLinks-multiSelect
branch
from
d6beea0 to
198356b
Compare
adrien-coye
force-pushed
the
externalLinks-multiSelect
branch
from
198356b to
6c88f15
Compare
… order to not risk breaking the inheritance stack.
7 tasks
PhilippeWeidmann
requested changes
Dec 19, 2024
There was a problem hiding this comment.
The DownloadQueue can handle different operations .
We already have DownloadOperation and DownloadArchiveOperation maybe you could subclass DownloadArchiveOperation with DownloadPublicShareArchiveOperation it passing shareDrive and publicShareProxy when you don't need it.
Also I think I missed it in an other review, but the same thing can be done for single files in DownloadOperation but the refactor should be done in a separate PR.
kDrive/UI/Controller/Files/File List/MultipleSelectionFileListViewModel.swift
Outdated
Show resolved
Hide resolved
…mmon-download-operation
adrien-coye
commented
Jan 7, 2025
…in operationsInQueue
|
PhilippeWeidmann
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
multi selectwork with a public share.Only one action,
Download allis available in this mode.Select allis also working with a dedicated route.Sub PRs:
Feature branch #1306