Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing forgot-password in pt-BR and save selected env on URL #333

Merged
merged 6 commits into from
Feb 21, 2023
Merged

Add missing forgot-password in pt-BR and save selected env on URL #333

merged 6 commits into from
Feb 21, 2023

Conversation

esau-morais
Copy link
Contributor

@esau-morais esau-morais commented Feb 15, 2023

Description

  1. Add missing forgot-password on pt-BR 🌎 Help us translate Infisical  #181
  2. Save selected workspace environment on URL using ?env= query param, so it can be sharable and prevent from resetting on refresh -> Append environment name to the dashboard page url #325

Screenshots

Before:
before

After:
image

2

Before
image

After
image

@esau-morais esau-morais changed the title Save selected env on URL Add missing forgot-password in pt-BR and save selected env on URL Feb 15, 2023
@maidul98 maidul98 requested a review from vmatsiiako February 19, 2023 06:44
@vmatsiiako
Copy link
Collaborator

This is really awesome! I found one minor bug: if you have a query param in your URL, layout will not should what tab is currently active. I just fixed it though :)

Screenshot 2023-02-20 at 20 26 39

Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for helping with this! This is really amazing! :)

@vmatsiiako vmatsiiako merged commit 07b307e into Infisical:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants