Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append environment name to the dashboard page url #325

Closed
maidul98 opened this issue Feb 10, 2023 · 8 comments
Closed

Append environment name to the dashboard page url #325

maidul98 opened this issue Feb 10, 2023 · 8 comments
Labels
🚀 feature request New feature or request good first issue Good for newcomers help wanted Open for contributions from the community

Comments

@maidul98
Copy link
Collaborator

Currently, the url for projects page looks like this regradress of what environment you are in

/dashboard/63e5ea1e7a65573dc1e20ee9

This is fine, but when you refresh the page you lose the environment you were in and then have to manually navigate to it. It would be better if it was more like this

/dashboard/63e5ea1e7a65573dc1e20ee9/{env name}

Example

/dashboard/63e5ea1e7a65573dc1e20ee9/dev
@maidul98 maidul98 added 🚀 feature request New feature or request good first issue Good for newcomers help wanted Open for contributions from the community labels Feb 10, 2023
@RashidUjang
Copy link
Contributor

Just throwing this out there, would it be sufficient if we were to use some sort of browser storage (IndexedDB or Local Storage) to store the environment of the user for this instead of changing the URL?

@dangtony98
Copy link
Collaborator

@RashidUjang Why not include it in the URL?

@RashidUjang
Copy link
Contributor

@dangtony98 I'm just exploring other ideas as I think it'd look neater not having in the URL as its sort of a temporary state that's useful only in the context of the user's current session (compared it with the Postman web client).

Just as I'm typing this though, having it in the URL does have an added benefit of making it easy to save & share a URL to go directly to an environment of a particular ID.

Feel free to dictate the direction, just adding some discourse!

@dangtony98
Copy link
Collaborator

Ah ya that makes sense.

The main benefit I see from having the env be in the URL is having the shareability component as you mentioned for sure!

And yea down for discourse as well; I think @maidul98 can chime in here.

@esau-morais
Copy link
Contributor

May I work on this issue?

@maidul98
Copy link
Collaborator Author

@RashidUjang Yes, I think having the env in the URL allows for better readability and keeps place on the dashboard if the user refreshes.

@esau-morais please, that would be great!

@RashidUjang
Copy link
Contributor

@maidul98 Sounds good and yes that definitely would ease sharing!

@vmatsiiako
Copy link
Collaborator

This is implemented now thanks to @esau-morais :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature request New feature or request good first issue Good for newcomers help wanted Open for contributions from the community
Projects
None yet
Development

No branches or pull requests

5 participants