-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pip installation #239
New pip installation #239
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #239 +/- ##
========================================
Coverage 67.69% 67.69%
========================================
Files 166 166
Lines 26709 26709
========================================
Hits 18081 18081
Misses 8628 8628 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installation with pip works on M2 Mac
After Ben's update of this pip, this pull request should not be needed anymore. |
Minor installation enhancement so that SHARPy can be installed automatically. Simply do
or
pip install -e .
for the developer mode.Extra packages are usually added for building the docs or for testing the code, since those are not needed by most users. If at some point testing is migrated to pytest (recommended), an entry would be added as "tests".
For instance, to install the basic + docs packages, just do
pip install .[docs]
. For the whole lot,pip install .[all]
CMake .. & make install
inside \build.One way to get around this in to use environment variables. So I added an option if someone absolutely don't want to do the compilation when doing pip install. Just set in the terminal
export PIP_NOBUILD=yes
prior topip install .
and it will install SHARPy without building the submodules.python setup.py build_subm
. And to add arguments, to compile in debug mode instead of Release, for example, just do:python setup.py build_subm --cmake-args="-DCMAKE_BUILD_TYPE=Debug"
I have noticed compiling in Debug mode give quite a few warnings that could be fixed in the xbeam library. To keep in mind if someone wants to do some cleaning. Same for the CMakeLists.text.
To be done
For the future