Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required Python version to 3.12 #694

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Update required Python version to 3.12 #694

merged 1 commit into from
Nov 6, 2024

Conversation

alexdewar
Copy link
Collaborator

Update pyproject.toml and regenerate poetry.lock file. Also update CI workflows to use Python 3.12.

I meant to test this in the lab, but didn't have enough time in the end. I'd be really surprised if it broke anything though (the tests pass and the GUI works fine with dummy devices), so I think we should just do it. I'll test it when I next go into the lab (hopefully next week) and we can always revert.

Closes #584.

@alexdewar alexdewar requested review from dalonsoa and dc2917 November 5, 2024 10:07
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (17c35fb) to head (dda027f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #694   +/-   ##
=======================================
  Coverage   84.97%   84.97%           
=======================================
  Files          69       69           
  Lines        3461     3461           
=======================================
  Hits         2941     2941           
  Misses        520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're are some things failing with links - presumably because of the removal of Codacy - and the tests are not running. It looks good, but I'll wait to approve until that is sorted.

Copy link
Contributor

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, tests are passing, but those are not the ones that are required. The settings need updating. As it turns out, I do not have Admin access. Have you, @alexdewar ?

Update pyproject.toml and regenerate poetry.lock file. Also update CI workflows to use Python 3.12.

Closes #584.
@alexdewar
Copy link
Collaborator Author

Thanks @dalonsoa. Yep, I'm an admin -- I've updated the rules. I've upgraded the team's permissions to admin too.

@alexdewar alexdewar enabled auto-merge November 6, 2024 10:01
@alexdewar alexdewar mentioned this pull request Nov 6, 2024
12 tasks
@alexdewar alexdewar merged commit d6cbde8 into main Nov 6, 2024
7 checks passed
@alexdewar alexdewar deleted the py312 branch November 6, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port to Python 3.12
2 participants