Display mirror angle

[dc2917]

Description

This PR adds the ability to display the current mirror angle on the GUI, as determined by the stepper motor controller.

The GUI should display the angle moved to (broadcast by the device once it has finished moving), or the name of the corresponding preset.

We'd like to also have the GUI indicate that the mirror is moving, however I don't think this is possible to test with the dummy device.

Fixes #583

Type of change

• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Documentation (non-breaking change that adds or improves the documentation)
• Optimisation (non-breaking, back-end change that speeds up the code)

Key checklist

• Pre-commit hooks run successfully (pre-commit run -a)
• All tests pass (pytest)
• The documentation builds without warnings (mkdocs build -s)
• Check the GUI still works (if relevant)
• Check the code works with actual hardware (if relevant)
• Check the pyinstaller-built executable works (if relevant)

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests have been added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (5ddc193) to head (e04340a).
Report is 20 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   86.92%   86.97%   +0.05%     
==========================================
  Files          69       69              
  Lines        3556     3570      +14     
==========================================
+ Hits         3091     3105      +14     
  Misses        465      465              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexdewar]

I've made some small suggestions. Besides that there are a couple of bugs:

1. The display shows the previous angle, not the current one (see comment)
2. The display will never show a "moving" state, because _update_mirror_position_display is only ever called when the motor has finished moving. To figure out when it has started moving you need to listen for the move.begin message instead. My PR might help with working on this: Add dummy stepper motor delay in default configuration #681

[alexdewar]

FYI: I'm just merging #694 and I've updated the required status checks for the Python 3.12 changes, so this branch will need updating before the checks pass now. You should just be able to do a simple merge/rebase.

[alexdewar]

Almost there I think! But it still won't display "moving" when the mirror is moving. See comment.

[alexdewar]

This is still something that needs tweaking if we want it to display "moving" when the mirror is moving. You need to have a separate handler which sets the text to moving when you get a move.begin message.

[alexdewar]

On reflection, I'm thinking it might be useful to see the angle for presets too. How about:

Suggested change

	preset = next((k for k, v in ANGLE_PRESETS.items() if v == moved_to), None)
	if preset:
	self.mirror_position_display.setText(preset.upper())
	else:
	self.mirror_position_display.setText(f"{moved_to}°")
	text = f"{moved_to}°"
	if preset := next((k for k, v in ANGLE_PRESETS.items() if v == moved_to), None):
	text += f" ({preset})"
	self.mirror_position_display.setText(text)

[dc2917]

This does display the names as, e.g. "cold_bb", rather than the text on the labels ("COLD BB"), but it's still obvious which each corresponds to haha

[alexdewar]

LGTM! Just need to resolve that merge conflict then this is ready to go 😄