Update custom samples with updated NwinData class. #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tishko0
previously approved these changes
Jan 9, 2024
HUSSAR-mtrela
requested changes
Jan 23, 2024
There was a problem hiding this comment.
@skrustev what's the reason for changing this data source?
Also, you should be making changes to NwindData in xplat repo because NwindData is auto-generated from there:
https://github.com/IgniteUI/igniteui-xplat-examples/blob/23.2.x/code-gen-library/NwindData/XPLAT.json
|
@skrustev can you please take a look at the comment from Martin |
|
@dkamburov Reminder about this PR still being open. |
|
This was back when the data generation was altered. This is for the custom samples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.