-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(advance-filtering): handle error when columns are dynamically changed - master #14525
Conversation
…into ganastasov/fix-14314-master
projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-advanced-filtering.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-advanced-filtering.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-advanced-filtering.component.ts
Outdated
Show resolved
Hide resolved
@ddincheva after a discussion with @gedinakova, we have decided that these PRs will focus solely on fixing the specific issue where error is thrown and advanced filtering dialog is not opened after the grid dataset is changed. No other changes or resets to the filters will be made in these PRs. After these PRs are merged, we will create a new task to address the user experience (UI/UX) aspect. This task will focus on how to effectively notify users about remaining applied filters in the advance filtering dialog after a dataset change, considering the best practices in UI/UX design. |
Closing this as it will duplicate with the mass merges. |
Closes #14314
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)