Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(advance-filtering): handle error when columns are dynamically changed - master #14525

Closed
wants to merge 8 commits into from

Conversation

georgianastasov
Copy link
Contributor

Closes #14314

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddincheva
Copy link
Contributor

When we have advanced filtering applied and change the grid data the grid is left in some incorrect state: the advanced filter counter is not reset but when you open the Advance filtering dialog you can see no filtering expression applied and also the grid's data is not displayed /cause the data is still filtered out/;
advFilteringAndRegenerating

@georgianastasov
Copy link
Contributor Author

When we have advanced filtering applied and change the grid data the grid is left in some incorrect state: the advanced filter counter is not reset but when you open the Advance filtering dialog you can see no filtering expression applied and also the grid's data is not displayed /cause the data is still filtered out/; advFilteringAndRegenerating

Again on my end, everything works as expected as you can see from the next gif!

2

@georgianastasov
Copy link
Contributor Author

@ddincheva after a discussion with @gedinakova, we have decided that these PRs will focus solely on fixing the specific issue where error is thrown and advanced filtering dialog is not opened after the grid dataset is changed. No other changes or resets to the filters will be made in these PRs.

After these PRs are merged, we will create a new task to address the user experience (UI/UX) aspect. This task will focus on how to effectively notify users about remaining applied filters in the advance filtering dialog after a dataset change, considering the best practices in UI/UX design.

@ChronosSF
Copy link
Member

Closing this as it will duplicate with the mass merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid Advanced Filtering throws if grid has recreated its columns colection
3 participants