Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Advanced Filtering throws if grid has recreated its columns colection #14314

Closed
hanastasov opened this issue Jun 3, 2024 · 1 comment · Fixed by #14527, #14577 or #14581
Closed

Grid Advanced Filtering throws if grid has recreated its columns colection #14314

hanastasov opened this issue Jun 3, 2024 · 1 comment · Fixed by #14527, #14577 or #14581
Assignees
Labels
🐛 bug Any issue that describes a bug grid: advanced-filtering grid ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@hanastasov
Copy link
Contributor

hanastasov commented Jun 3, 2024

Steps to reproduce

  1. Add grid with Advanced filtering (you can use the GridFilteringComponent in dev demos
  2. Through Advanced filtering dialog, filter some column, lets say CompanyName
  3. Change the collection, which the grid uses to create columns based on;

this.columns = this.columns2; // columns2 has different columns than columns

OR change the grid data and have tje grid auto generate its columns:

        this.grid1.shouldGenerate = true;
        this.data = this.data3;
  1. Open Advanced Filtering dialog

Result

Error is thrown and Advanced filtering dialog is not opened
image

@hanastasov hanastasov added 🐛 bug Any issue that describes a bug 🆕 status: new grid labels Jun 3, 2024
@hanastasov hanastasov self-assigned this Jun 5, 2024
@georgianastasov georgianastasov added 🛠️ status: in-development Issues and PRs with active development on them grid: advanced-filtering and removed 🆕 status: new labels Jul 12, 2024
@georgianastasov georgianastasov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 16, 2024
@georgianastasov georgianastasov added 🛠️ status: in-development Issues and PRs with active development on them ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. 🛠️ status: in-development Issues and PRs with active development on them labels Jul 22, 2024
@georgianastasov
Copy link
Contributor

We have decided that the PRs for this issue will focus solely on fixing the specific issue where error is thrown and advanced filtering dialog is not opened after the grid dataset is changed. No other changes or resets to the filters will be made in the PRs for this issue.

After the PRs for this issue are merged, we will create a new task to address the user experience (UI/UX) aspect. This task will focus on how to effectively notify users about remaining applied filters in the advance filtering dialog after a dataset change, considering the best practices in UI/UX design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment