Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): implement updated Indigo UI theme #13948

Merged
merged 43 commits into from
Mar 13, 2024
Merged

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Feb 23, 2024

Closes #

  • Avatar
  • Badge
  • Banner
  • Button
  • Button Group
  • Card
  • Carousel
  • Checkbox
  • Divider
  • Expansion Panel
  • Icon
  • Icon Button
  • Input
  • Radio
  • Snackbar

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff marked this pull request as draft February 23, 2024 09:16
@sbayreva
Copy link

Avatar

  1. In Light Mode the color of the icon should be Grays 600

@sbayreva
Copy link

Checkbox

  1. In Light Mode label color in Invalid Hover state should be Grays 900
  2. In Light and Dark mode label font should be Body 2
  3. In Dark Mode Error color of Invalid state should be Error 400
  4. In Dark Mode Error color of Invalid Hover state should be Error 300
  5. In Dark Mode the color of the label in Invalid Hover state should be white

@sbayreva
Copy link

sbayreva commented Feb 29, 2024

Dialog

  1. In Dark Mode the elevation should be 23
    @andiesm813 Please, confirm the elevation in Dark Mode.

In Both Dark and Light Mode

  1. The font of the message should be Body 1
  2. The size of the buttons should be Medium
  3. The Primary Action should be with Contained Button and the Secondary with Outlined.

@AnjiManova
Copy link

AnjiManova commented Feb 29, 2024

Button

  1. Contained/Large in Light and Dark theme -> The space between the Icon and Label in the Indigo UI kit is 8px; currently, the implementation is 12px.

Comment edited: This is fixed

@SisIvanova SisIvanova marked this pull request as ready for review March 11, 2024 11:58
@hanastasov
Copy link
Contributor

hanastasov commented Mar 11, 2024

@deyvidnenchev , please have a look at the build error. @kdinev and @damyanpetev assume this is due to a change in nx. Here is a link with more info too

https://stackoverflow.com/a/77989040

Edit: It seemed Konstantin already resolved the issue.

@simeonoff simeonoff added the ❌ status: awaiting-test PRs awaiting manual verification label Mar 11, 2024
@desig9stein desig9stein added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 11, 2024
desig9stein
desig9stein previously approved these changes Mar 11, 2024
@desig9stein desig9stein added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Mar 11, 2024
@desig9stein desig9stein self-assigned this Mar 12, 2024
@kdinev kdinev merged commit 16f32b0 into master Mar 13, 2024
6 checks passed
@kdinev kdinev deleted the simeonoff/indigo-theme branch March 13, 2024 09:13
@SisIvanova SisIvanova mentioned this pull request Mar 13, 2024
14 tasks
@SisIvanova SisIvanova mentioned this pull request Mar 20, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: verified indigo-theme version: 17.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.