Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog): update indigo dialog paddings #13937

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

didimmova
Copy link
Contributor

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copy link
Collaborator

@SisIvanova SisIvanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the title should use H5 styles not H6
  • the background should be white instead of surface color
  • the elevation level in dark mode should be 23 instead of 24 (may be bug in the UI kit)
  • wrong content color in dark mode

@simeonoff simeonoff changed the base branch from master to simeonoff/indigo-theme February 23, 2024 09:08
@simeonoff simeonoff merged commit fd5139d into simeonoff/indigo-theme Feb 23, 2024
5 of 6 checks passed
@simeonoff simeonoff deleted the didimmova/indigo-dialog branch February 23, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indigo: Dialog Component
4 participants