Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Frontend: Improve 3D mesh viewer defaults #4606

Merged
merged 7 commits into from
Aug 14, 2023
Merged

🎨 Frontend: Improve 3D mesh viewer defaults #4606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0288b0
larger StudyThumbnailExplorer
odeimaiz Aug 11, 2023
4c12f4e
remove grid
odeimaiz Aug 11, 2023
7eb1967
more intense light
odeimaiz Aug 11, 2023
19f8563
camera position
odeimaiz Aug 11, 2023
bf96726
less intense
odeimaiz Aug 11, 2023
d661fe1
Merge branch 'master' into feature/mesh-viewer-improvements
odeimaiz Aug 11, 2023
4f3fa39
Merge branch 'feature/mesh-viewer-improvements' of github.com:odeimai…
odeimaiz Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/static-webserver/client/source/class/osparc/component/widget/Three.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ qx.Class.define("osparc.component.widget.Three", {
this.getContentElement().getDomElement()
.appendChild(this.__threeWrapper.getDomElement());

// this.__threeWrapper.SetCameraPosition(18, 0, 25);
this.__threeWrapper.setCameraPosition(210, 210, 90); // Z up
// this.__threeWrapper.setCameraPosition(18, 0, 25);
this.__threeWrapper.setCameraPosition(300, 300, 300);
this.__threeWrapper.setBackgroundColor("#484f54");
this.__resized();

Expand Down
4 changes: 2 additions & 2 deletions services/static-webserver/client/source/class/osparc/dashboard/StudyThumbnailExplorer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ qx.Class.define("osparc.dashboard.StudyThumbnailExplorer", {
},

statics: {
LAYOUT_HEIGHT: 300,
LAYOUT_HEIGHT: 320,
NODES_TREE_WIDTH: 160,
THUMBNAIL_SLIDER_HEIGHT: 40
THUMBNAIL_SLIDER_HEIGHT: 60
},

members: {
Expand Down
7 changes: 4 additions & 3 deletions services/static-webserver/client/source/class/osparc/wrapper/Three.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ qx.Class.define("osparc.wrapper.Three", {

this.__camera = new THREE.PerspectiveCamera();
this.__camera.far = 10000;
this.__camera.up.set(0, 0, 1);
// this.__camera.up.set(0, 0, 1); // Z up
this.__scene.add(this.__camera);

this.__addCameraLight();
this.__addGridHelper();
// this.__addGridHelper();
this.__addAxesHelper();

this.__mouse = new THREE.Vector2();
Expand Down Expand Up @@ -332,7 +332,8 @@ qx.Class.define("osparc.wrapper.Three", {
},

__addCameraLight: function() {
const pointLight = new THREE.PointLight(0xFFFFFF);
// color and intensity
const pointLight = new THREE.PointLight(0xFFFFFF, 2.5);
pointLight.position.set(1, 1, 2);
this.__camera.add(pointLight);
},
Expand Down