Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Frontend: Improve 3D mesh viewer defaults #4606

Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 11, 2023

What do these changes do?

  • Fix camera initial position
  • Increase light intensity
  • Make thumbnail explorer larger

ThreeJS

Related issue/s

How to test

DevOps Checklist

@odeimaiz odeimaiz self-assigned this Aug 11, 2023
@odeimaiz odeimaiz changed the title 🎨 Frontend: Improve 3d mesh viewer defaults 🎨 Frontend: Improve 3D mesh viewer defaults Aug 11, 2023
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shall be light!

@odeimaiz odeimaiz enabled auto-merge (squash) August 11, 2023 15:41
…z/osparc-simcore into feature/mesh-viewer-improvements
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 11, 2023

Code Climate has analyzed commit 4f3fa39 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks for this one!

@odeimaiz odeimaiz merged commit 3a42b86 into ITISFoundation:master Aug 14, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants