Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Frontend: Improvements to tagging functionality #4052

Merged
merged 24 commits into from
Apr 5, 2023
Merged

🎨 Frontend: Improvements to tagging functionality #4052

merged 24 commits into from
Apr 5, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 3, 2023 •
edited
Loading

What do these changes do?

  • Add a Tags tab on the More Options view
  • Add a direct access to Tagging on the Study Card
  • Add a button to create new tags from the Tag Manager
  • Add the newly created tag to the list of tags

TagsUX

Related issue/s

closes ITISFoundation/osparc-issues#914

How to test

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Apr 3, 2023
@odeimaiz odeimaiz self-assigned this Apr 3, 2023
@odeimaiz odeimaiz added this to the Jelly Beans milestone Apr 3, 2023
@odeimaiz odeimaiz changed the title WIP 🎨 Frontend: TagManager UX WIP 🎨 Frontend: Improvements to tagging functionality Apr 3, 2023
@odeimaiz odeimaiz marked this pull request as ready for review April 4, 2023 08:19
@odeimaiz odeimaiz changed the title WIP 🎨 Frontend: Improvements to tagging functionality 🎨 Frontend: Improvements to tagging functionality Apr 4, 2023
@odeimaiz odeimaiz requested a review from mguidon April 4, 2023 08:20
GitHK
GitHK reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@odeimaiz odeimaiz enabled auto-merge (squash) April 4, 2023 09:04
elisabettai
elisabettai approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very cool, thanks!

@codeclimate
Copy link

codeclimate bot commented Apr 5, 2023

Code Climate has analyzed commit e5e2bad and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit 1e7a0af into ITISFoundation:master Apr 5, 2023
@odeimaiz odeimaiz deleted the feature/tags-ux branch April 6, 2023 18:42
This was referenced Apr 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@elisabettai elisabettai elisabettai approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Jelly Beans
Development

Successfully merging this pull request may close these issues.

Improvements to tagging functionality
6 participants
@odeimaiz @GitHK @elisabettai @pcrespov @sanderegg @matusdrobuliak66