♻️ Is638/dynamic sidecar refactors tests (round 3)

[pcrespov]

Follows from PR #3152 (when you review this notice that, if the former PR is still not merged into master, the list of Files changed will also include its files).

What do these changes do?

The main goal of the PR is to simplify the test infrastructure, in particular the fixtures that patch/mock env vars and functionality.

• ♻️ test refactoring strategy (see comments in code):
  • env vars are used to configure application
  • mock_environment defines a base app config suitable for unit-tests
  • overriding this configuration -> produces a different app fixture
• Other changes:
  • ✨ AppState is a decorator class helper
  • ♻️ replaced DY_VOLUME global constant. Now in app.settings captured from DY_VOLUME env (i.e. syncs with Dockerfile)
  • 🔨 scripts/Makefile recipe to display settings: make info

Related issue/s

• improving dynamic-sidecar design osparc-issues#638

How to test

CI

Checklist

• Openapi changes? make openapi-specs, git commit ... and then make version-*)
• Database migration script? cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
• Unit tests for the changes exist
• Runs in the swarm
• Documentation reflects the changes
• New module? Add your github username to .github/CODEOWNERS

[codecov]

Codecov Report

Merging #3154 (0750896) into master (89cf160) will decrease coverage by 0.0%.
The diff coverage is 92.5%.

@@           Coverage Diff            @@
##           master   #3154     +/-   ##
========================================
- Coverage    81.1%   81.0%   -0.1%     
========================================
  Files         711     711             
  Lines       30630   30646     +16     
  Branches     3948    3949      +1     
========================================
+ Hits        24844   24853      +9     
- Misses       4948    4951      +3     
- Partials      838     842      +4     

Flag	Coverage Δ
integrationtests	66.2% <ø> (+<0.1%)	⬆️
unittests	77.4% <92.5%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...sidecar/src/simcore_service_dynamic_sidecar/cli.py	0.0% <0.0%> (ø)
...ice_dynamic_sidecar/models/domains/shared_store.py	100.0% <ø> (ø)
...namic_sidecar/models/schemas/application_health.py	100.0% <ø> (ø)
...imcore_service_dynamic_sidecar/core/application.py	95.8% <100.0%> (-0.7%)	⬇️
...c/simcore_service_dynamic_sidecar/core/settings.py	94.2% <100.0%> (-3.9%)	⬇️
...core_service_dynamic_sidecar/modules/mounted_fs.py	100.0% <100.0%> (ø)
...ore_service_director_v2/utils/client_decorators.py	73.3% <0.0%> (-3.4%)	⬇️
...imcore_service_dynamic_sidecar/core/docker_logs.py	87.5% <0.0%> (-3.2%)	⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py	86.7% <0.0%> (-1.9%)	⬇️
... and 11 more

[GitHK]

This is not the first time I see it, but what is the advantage in adding this comma?

[pcrespov]

It is a visual aid. I add it to enforce black to create multiline so the json-like structure looks like yaml. That would be

services:
    first-box:
        image: busybox
        networks:
           - dynamic_sidecar_ntework_name

It helps me seeing better all sections since we are used to yaml more than json for the compose specs.
It is a small thing that I can also reverse

[sanderegg]

great! thanks!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.4% Duplication