Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ ✨ Is638/adds CLI to dynamic-sidecar (round 2) #3152

Merged
merged 9 commits into from
Jun 29, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 28, 2022

Follows from PR #3147 (when you review this notice that, if the former PR is still not merged into master, the list of Files changed will also include it's files).

What do these changes do?

  • ✨ Adds CLI and entrypoint to the service
(.venv) ➜  simcore-service-dynamic-sidecar --help
ujson module not found, using json
msgpack not installed, MsgPackSerializer unavailable
Usage: simcore-service-dynamic-sidecar [OPTIONS] COMMAND [ARGS]...

Options:
  --help                          Show this message and exit.

Commands:
  openapi   Prints OpenAPI specifications in json format
  settings  Resolves settings and prints envfile
  • 🔨 Makefile recipe to produce openapi.json

Related issue/s

How to test

CI

Checklist

  • Openapi changes? make openapi-specs, git commit ... and then make version-*)
  • Database migration script? cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov self-assigned this Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #3152 (2f62ff6) into master (7b11dd1) will decrease coverage by 0.0%.
The diff coverage is 55.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3152     +/-   ##
========================================
- Coverage    81.1%   81.1%   -0.1%     
========================================
  Files         710     711      +1     
  Lines       30613   30630     +17     
  Branches     3948    3948             
========================================
+ Hits        24841   24845      +4     
- Misses       4930    4944     +14     
+ Partials      842     841      -1     
Flag Coverage Δ
integrationtests 66.3% <ø> (+0.1%) ⬆️
unittests 77.4% <55.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sidecar/src/simcore_service_dynamic_sidecar/cli.py 0.0% <0.0%> (ø)
...idecar/src/simcore_service_dynamic_sidecar/main.py 0.0% <0.0%> (ø)
...imcore_service_dynamic_sidecar/core/application.py 96.4% <91.6%> (+0.1%) ⬆️
...ector_v2/modules/comp_scheduler/background_task.py 83.3% <0.0%> (-8.4%) ⬇️
...ore_service_director_v2/utils/client_decorators.py 73.3% <0.0%> (-3.4%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 86.7% <0.0%> (-1.9%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.7% <0.0%> (-1.5%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 76.5% <0.0%> (-1.1%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 92.2% <0.0%> (-0.6%) ⬇️
...mcore_service_webserver/garbage_collector_utils.py 84.6% <0.0%> (+2.5%) ⬆️
... and 2 more

@pcrespov pcrespov changed the title WIP: Is638/adds CLI to dynamic-sidecar WIP: Is638/adds CLI to dynamic-sidecar (2nd round) Jun 28, 2022
@pcrespov pcrespov changed the title WIP: Is638/adds CLI to dynamic-sidecar (2nd round) WIP: ♻️ ✨ Is638/adds CLI to dynamic-sidecar (round 2) Jun 28, 2022
@pcrespov pcrespov added the a:dynamic-sidecar dynamic-sidecar service label Jun 28, 2022
@pcrespov pcrespov added this to the Diolkos milestone Jun 28, 2022
@pcrespov pcrespov force-pushed the is638/dy-sidecar-cli branch 2 times, most recently from a626928 to e20973a Compare June 28, 2022 15:51
@pcrespov pcrespov force-pushed the is638/dy-sidecar-cli branch from e20973a to 9ba69a5 Compare June 28, 2022 16:41
@pcrespov pcrespov changed the title WIP: ♻️ ✨ Is638/adds CLI to dynamic-sidecar (round 2) ♻️ ✨ Is638/adds CLI to dynamic-sidecar (round 2) Jun 28, 2022
@pcrespov pcrespov requested review from GitHK, sanderegg and mguidon June 28, 2022 16:42
@pcrespov pcrespov marked this pull request as ready for review June 28, 2022 16:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov merged commit 89cf160 into ITISFoundation:master Jun 29, 2022
@pcrespov pcrespov deleted the is638/dy-sidecar-cli branch June 29, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants