-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Avoids locking the dynamic-sidecar in an error state #2928
Merged
GitHK
merged 5 commits into
ITISFoundation:master
from
GitHK:fix-dysdcr-control-key-missing
Mar 29, 2022
Merged
🐛 Avoids locking the dynamic-sidecar in an error state #2928
GitHK
merged 5 commits into
ITISFoundation:master
from
GitHK:fix-dysdcr-control-key-missing
Mar 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
added
bug
buggy, it does not work as expected
changelog:🐛bugfix
a:director-v2
issue related with the director-v2 service
labels
Mar 29, 2022
…arc-simcore-forked into fix-dysdcr-control-key-missing
pcrespov
approved these changes
Mar 29, 2022
elisabettai
approved these changes
Mar 29, 2022
Codecov Report
@@ Coverage Diff @@
## master #2928 +/- ##
========================================
- Coverage 79.6% 79.5% -0.1%
========================================
Files 677 677
Lines 28227 28228 +1
Branches 3281 3282 +1
========================================
- Hits 22469 22467 -2
+ Misses 4998 4995 -3
- Partials 760 766 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
approved these changes
Mar 29, 2022
...ices/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/events.py
Outdated
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes an issue where the director-v2 cannot find the node in the network aliases.
Related issue/s
How to test
Checklist