Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Avoids locking the dynamic-sidecar in an error state #2928

Merged
merged 5 commits into from
Mar 29, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 29, 2022

What do these changes do?

Fixes an issue where the director-v2 cannot find the node in the network aliases.

Related issue/s

How to test

Checklist

@GitHK GitHK requested a review from elisabettai March 29, 2022 15:22
@GitHK GitHK self-assigned this Mar 29, 2022
@GitHK GitHK added bug buggy, it does not work as expected changelog:🐛bugfix a:director-v2 issue related with the director-v2 service labels Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #2928 (d15db21) into master (5f6c8d3) will decrease coverage by 0.0%.
The diff coverage is 66.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2928     +/-   ##
========================================
- Coverage    79.6%   79.5%   -0.1%     
========================================
  Files         677     677             
  Lines       28227   28228      +1     
  Branches     3281    3282      +1     
========================================
- Hits        22469   22467      -2     
+ Misses       4998    4995      -3     
- Partials      760     766      +6     
Flag Coverage Δ
integrationtests 65.7% <66.6%> (+<0.1%) ⬆️
unittests 75.1% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 94.4% <66.6%> (-0.6%) ⬇️
...rvice_datcore_adapter/utils/requests_decorators.py 71.0% <0.0%> (-7.9%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.4% <0.0%> (-1.6%) ⬇️
.../simcore_service_catalog/services/access_rights.py 80.0% <0.0%> (-1.3%) ⬇️
.../director/src/simcore_service_director/producer.py 61.9% <0.0%> (-1.3%) ⬇️
...ore_service_director_v2/utils/dask_client_utils.py 79.1% <0.0%> (+0.8%) ⬆️
...imcore_service_webserver/garbage_collector_core.py 71.4% <0.0%> (+0.9%) ⬆️
.../src/simcore_service_webserver/director_v2_core.py 75.4% <0.0%> (+0.9%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 78.2% <0.0%> (+0.9%) ⬆️
...c/simcore_service_catalog/core/background_tasks.py 68.4% <0.0%> (+2.1%) ⬆️
... and 1 more

@GitHK GitHK merged commit 7ae21de into ITISFoundation:master Mar 29, 2022
@GitHK GitHK deleted the fix-dysdcr-control-key-missing branch March 29, 2022 17:10
@sanderegg sanderegg added this to the E.Shackleton milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants