Skip to content

Commit

Permalink
πŸ› Avoids locking the dynamic-sidecar in an error state (#2928)
Browse files Browse the repository at this point in the history
* fix missing key, if not found this should be skipped

* using default

Co-authored-by: Andrei Neagu <[email protected]>
  • Loading branch information
GitHK and Andrei Neagu authored Mar 29, 2022
1 parent 5f6c8d3 commit 7ae21de
Showing 1 changed file with 9 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -428,14 +428,15 @@ async def action(cls, app: FastAPI, scheduler_data: SchedulerData) -> None:
network_name,
container_aliases,
) in projects_networks.networks_with_aliases.items():
network_alias = container_aliases[f"{scheduler_data.node_uuid}"]
await dynamic_sidecar_client.attach_service_containers_to_project_network(
dynamic_sidecar_endpoint=dynamic_sidecar_endpoint,
dynamic_sidecar_network_name=scheduler_data.dynamic_sidecar_network_name,
project_network=network_name,
project_id=scheduler_data.project_id,
network_alias=network_alias,
)
network_alias = container_aliases.get(f"{scheduler_data.node_uuid}")
if network_alias is not None:
await dynamic_sidecar_client.attach_service_containers_to_project_network(
dynamic_sidecar_endpoint=dynamic_sidecar_endpoint,
dynamic_sidecar_network_name=scheduler_data.dynamic_sidecar_network_name,
project_network=network_name,
project_id=scheduler_data.project_id,
network_alias=network_alias,
)

scheduler_data.dynamic_sidecar.is_project_network_attached = True

Expand Down

0 comments on commit 7ae21de

Please sign in to comment.