Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ Maintenance/week 25: updates of testing, tooling and vulnerable libraries #2394

Merged
merged 26 commits into from
Jun 21, 2021

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 21, 2021

What do these changes do?

  • CHANGE: vulnerability upgrades of aiohttp and urllib3 (reported by dependabot)
  • CHANGE: upgrades all testing and tooling dependencies
  • FIX: missing dependencies in sidecar requirement files
  • CHANGE: scripts/codestyle.bash now installs all missing stub packages (e.g. types-PyYAML, types-aiofiles, etc)

NOTE: opened issue #2393 to keep a backlog of all features missing for requirements upgrade.

Related issue/s

Weekly maintenance

How to test

Affected all repo tests

@pcrespov pcrespov self-assigned this Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #2394 (36ddfe4) into master (32f6501) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2394     +/-   ##
========================================
- Coverage    74.2%   74.2%   -0.1%     
========================================
  Files         518     518             
  Lines       20320   20320             
  Branches     2012    2012             
========================================
- Hits        15093   15090      -3     
- Misses       4708    4709      +1     
- Partials      519     521      +2     
Flag Coverage Δ
integrationtests 67.3% <ø> (-0.1%) ⬇️
unittests 67.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...webserver/computation_comp_tasks_listening_task.py 80.6% <0.0%> (-3.1%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 72.4% <0.0%> (-0.9%) ⬇️
...simcore_service_webserver/projects/projects_api.py 83.5% <0.0%> (-0.4%) ⬇️
...c/simcore_service_director_v2/modules/scheduler.py 98.3% <0.0%> (+1.6%) ⬆️
...-v2/src/simcore_service_director_v2/core/errors.py 61.1% <0.0%> (+2.7%) ⬆️

@pcrespov pcrespov added dependencies t:maintenance Some planned maintenance work labels Jun 21, 2021
@pcrespov pcrespov added this to the Marmoset milestone Jun 21, 2021
@pcrespov pcrespov marked this pull request as ready for review June 21, 2021 11:36
@pcrespov pcrespov changed the title WIP: 🏗️ Maintenance/week 25: updates of testing, tooling and vulnerable libraries 🏗️ Maintenance/week 25: updates of testing, tooling and vulnerable libraries Jun 21, 2021
Copy link
Contributor

@colinRawlings colinRawlings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice - just some small questions

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still use 2 different mypy, with probably even different versions. not sure why. anyway is out of the scope of that PR.

scripts/codestyle.bash Show resolved Hide resolved
@pcrespov pcrespov merged commit 3ab3bf6 into ITISFoundation:master Jun 21, 2021
@pcrespov pcrespov deleted the maintenance/week-25 branch June 21, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants