Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove units sp option, add vent status and SP #1631

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

rerpha
Copy link
Contributor

@rerpha rerpha commented Oct 25, 2023

Description of work

Add your own description here

Ticket

Link to Ticket

Acceptance criteria

List the acceptance criteria for the PR. The aim is provide information to help the reviewer

Unit tests

Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer

System tests

Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer


Code Review

Final Steps

@Chsudeepta
Copy link
Contributor

reviewed and found OK

@Chsudeepta Chsudeepta merged commit 3735444 into master Oct 30, 2023
@rerpha rerpha deleted the Ticket8070 branch October 30, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants