Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keithley 2290 HV power supply #7468

Closed
4 tasks
Tom-Willemsen opened this issue Nov 7, 2022 · 6 comments
Closed
4 tasks

Keithley 2290 HV power supply #7468

Tom-Willemsen opened this issue Nov 7, 2022 · 6 comments
Assignees

Comments

@Tom-Willemsen
Copy link
Contributor

Where?

As an electronics technician supporting HV experiments I would like a Keithley 2290-10 power supply to be supported in IBEX.

We have just purchased a new power supply that has RS232 comms. We would love to get this added to IBEX when possible.
We are not screaming for it per se but would greatly increase our capabilities
You can physically have the unit if it helps you.

The PSU will just be used for any HV experiments, generally field type experiments and also CHIPIR have a lot of HV experiments. Full control would be ideal please.
I can also physically drop off the unit if you believe this to be of help.

Acceptance criteria

  • Keithley 2290-10 can be controlled in IBEX
  • Has emulator
  • Has tests
  • Has OPI

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)

@pheest
Copy link
Contributor

pheest commented Dec 20, 2022

The system has not yet been tested with the output enabled as the hardware required to do so is not yet fully in place.
I believe it should work, but in particular the operation of trips and alarms needs to be reviewed.

@pheest
Copy link
Contributor

pheest commented Dec 20, 2022

Tests run from C:\Instrument\Apps\EPICS\support\Keithley_2290\master with 'make ioctests'.

@FreddieAkeroyd
Copy link
Member

FreddieAkeroyd commented Jan 23, 2023

Equipment is not static and can be moved away from a beam line and then brought back for a different experiment, so we need to be careful about what we autosave and apply/pini so as not to cause surprises. Thus we need to be careful about $(P)VOLT:SP and $(P)VOLT_ON:SP. In general we should not automatically turn a supply on when the ioc starts, we would instead just initialise its PV value to something appropriate by using e.g. stream device @init handler. So VOLT_ON should definitely not be PINI, VOLT:SP probably not either as somebody could connect a power supply that they have turned on and set a value by the front panel, then start the ioc and the voltage could jump to the value from a previous experiment. So i think it is best if both these were not PINI/autosave but instead used something like @init stream device handlers to initialise themselves to the current hardware value, but if it is not possible to read this from the hardware we may need to discuss the best option.

@pheest
Copy link
Contributor

pheest commented Jan 24, 2023

This approach is possible, except for the $(P)VOLT_ON:SP value which is not readable as a setpoint value.
Trying to use the VOLT_ON status readback to initialise the setpoint creates some interesting chicken-or-egg issues.

@KathrynBaker KathrynBaker removed this from the SPRINT_2023_01_05 milestone Feb 2, 2023
@FreddieAkeroyd
Copy link
Member

Thank you for your work on this. I seem to have a problem with turning the supply on/off against the emulator, the system test for turning on did not check the actual readback status, when i changed it to do this it failed. If i try to turn it on and off from the gui, the led for on never lights up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants