Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keithley 2290 HV power supply testing - with suitable load fitted #7568

Closed
4 tasks
pheest opened this issue Jan 16, 2023 · 3 comments
Closed
4 tasks

Keithley 2290 HV power supply testing - with suitable load fitted #7568

pheest opened this issue Jan 16, 2023 · 3 comments
Assignees
@pheest
Labels
2 no_release_notes Tickets that do not need release notes, use sparingly!
Milestone
SPRINT_2023_02_02

Comments

@pheest
Copy link
Contributor

pheest commented Jan 16, 2023

Where?

This ticket follows #7468 Keithley 2290 HV power supply, which was closed without completing all tests because no suitable load for the power supply had yet been fitted.

How?

A suitable load has now been fitted to the test supply.
This allows testing to proceed.

Reproducible?

[N/A]

To Reproduce

Acceptance criteria

  • Tested to set voltage.
  • Tested to set voltage and current limits.
  • Tested to limit or trip when limits are exceeded.
  • Tested for recovery from trip scenarios.

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)
@pheest pheest self-assigned this Jan 16, 2023
@pheest pheest added the ready label Jan 16, 2023
@pheest pheest added this to the SPRINT_2023_01_05 milestone Jan 16, 2023
@pheest pheest added the 2 label Jan 16, 2023
@pheest pheest added in progress and removed ready labels Jan 19, 2023
@pheest
Copy link
Contributor Author

pheest commented Jan 20, 2023

ISISComputingGroup/EPICS-KeithleyHVPS#1
https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Keithley-2290

@pheest pheest added review and removed in progress labels Jan 20, 2023
@pheest pheest added the no_release_notes Tickets that do not need release notes, use sparingly! label Jan 24, 2023
@rerpha
Copy link
Contributor

rerpha commented Jan 27, 2023 •
edited
Loading

I am going to put this in impeded as I think #7468 needs to be reviewed and merged first

@github-actions github-actions bot added impeded and removed review labels Jan 27, 2023
@FreddieAkeroyd
Copy link
Member

FreddieAkeroyd commented Feb 5, 2023 •
edited
Loading

Will merge with exisiting review as PR here was in response to comments there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pheest pheest

Labels
2 no_release_notes Tickets that do not need release notes, use sparingly!
Projects
None yet
Milestone
SPRINT_2023_02_02
Development

No branches or pull requests
4 participants
@FreddieAkeroyd @KathrynBaker @rerpha @pheest