Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend TPG IOC to include the variations for the 500 series #7458

Closed
4 tasks
KathrynBaker opened this issue Nov 2, 2022 · 3 comments
Closed
4 tasks

Extend TPG IOC to include the variations for the 500 series #7458

KathrynBaker opened this issue Nov 2, 2022 · 3 comments
Assignees
Labels
3 for release Required for next release rework

Comments

@KathrynBaker
Copy link
Member

KathrynBaker commented Nov 2, 2022

As someone reading pressures in IBEX I want to be able to do so from the most recent version of Pfeiffer Vacuum Gauge in use at ISIS.

Acceptance Criteria

  • Chase up if hardware is available, if not, create a new ticket to test with hardware, and reduce the points on this ticket appropriately
  • The emulator is refactored to accommodate both models of the TPG
  • There are dbs, protos, substitute, and templates as appropriate for the 500 series TPGs
  • Wiki page for the TPG500 is added

Notes

  • These will not be available imminently, but will be made available to us once they are on site (expected in early 2023), as such this is not to be picked up too early
  • The existing IOC deals with 26x and 36x models the 300 model, so extending this to the 500 series should be straightforward to implement as similar functionality is already in place
  • This model will be used in both the INTER and SURF upgrades that are due to be undertaken in 2023
@boeuf-codes
Copy link
Contributor

boeuf-codes commented Jun 28, 2023

Note: as part of this ticket, some suspicions about the TPG300 were hardware tested.

  • TPG300s confirmed using <CR><LF> as a terminator for all commands
  • Remains unseen whether the repeated B1 for SPx is a typo or not (see TPGx00: Fix device niggles #7860)

@KathrynBaker KathrynBaker added the for release Required for next release label Aug 7, 2023
@zsoltkebel
Copy link
Contributor

zsoltkebel commented Aug 8, 2023

For the reviewer

If you confirm that the device now behaves correctly please clarify that this ticket is not relevan anymore:

as well as remove the "known issues" part accordingly from the wiki:

See this wiki page on how to test commands sent directly to device or emulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 for release Required for next release rework
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants