-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MercuryiTC IOC: update pattern for TEMP/LEVEL/PRESSURE macros #7322
Comments
ConfigChecker test for checking macro value pattern match:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Where?
See
\\ioc\master\MERCURY_ITC\iocBoot\iocMERCURY-IOC-01
.As of writing this issue, all MercuryiTC TEMP, LEVEL and PRESSURE macros (not ones with the old
VI_...
prefix) have values in the formatletters.letters
(I will comment a test to be able to check this is still the case). This format is also shared by Newport XPS-D controllers.However, the regex pattern for MercuryiTC is
^.*$
, which is exactly anything, whereas for Newport XPS-D it is^.*[.].*$
, which describes the pattern specified above.Therefore, it seems sensible to update the pattern values for MercuryiTC TEMP, LEVEL and PRESSURE macros.
Acceptance criteria
^.*[.].*$
How to Test
verbose instructions for reviewer to test changes
(Add before making a PR)
The text was updated successfully, but these errors were encountered: