Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update level/pressure/temp macro patterns #728

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

boeuf-codes
Copy link
Contributor

@boeuf-codes boeuf-codes commented Sep 14, 2022

Description of work

Ticket #7322
Updated TEMP/LEVEL/PRESSURE macros from ^.*$ to ^.[.].$

Note: when macros were changed, all current mercury temp/level/pressure macro values adhered to the pattern (except the ones which are undefined as "", which is also valid)

Acceptance criteria

  • Rectify the regex patterns for TEMP, LEVEL and PRESSURE macros to ^.*[.].*$
  • No TEMP, LEVEL and PRESSURE macro values mismatch this pattern after the change

Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@Tom-Willemsen Tom-Willemsen merged commit 3c1a992 into master Sep 15, 2022
@Tom-Willemsen Tom-Willemsen deleted the Ticket_7322 branch September 15, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants