Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with home found during Huber Hardware testing. [Timebox: 2 days] #7277

Closed
2 tasks
LowriJenkins opened this issue Aug 3, 2022 · 2 comments
Closed
2 tasks
Assignees
Labels

Comments

@LowriJenkins
Copy link
Contributor

The Huber does has a couple of small issues when homing that should be fixed:

  • It fails to home properly under some circumstances on hardware (appears to be when at a limit, may be more specificly while near home and at a limit). This leads to it not properly removeing the flag to home, and thus homing as soon as it finishes a move that brings it away from said limit.
  • The setpoint often ends up a nonsense value after homing, it should instead be set to 0 like the value is.

Where?

C:\Instrument\Apps\EPICS\support\motorHuber\master\huberApp\src\SMC9300Driver.cpp

Acceptance criteria

  • The Huber homes properly while at a limit, or at least does not immediatly home when moved away from the limit after attempting to home it and it getting stuck.
  • The setpoint is properly set to 0 alongside the value.

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)

@LowriJenkins
Copy link
Contributor Author

The huber will be used in experiments during november, none of neither of these issues would prevent use, however they would be nice to have fixed if possible.

LowriJenkins pushed a commit that referenced this issue Aug 12, 2022
@KathrynBaker KathrynBaker changed the title Fix issues with home found during Huber Hardware testing. Fix issues with home found during Huber Hardware testing. [Timebox: 2 days] Sep 8, 2022
@KathrynBaker KathrynBaker added 8 and removed proposal labels Sep 8, 2022
@github-actions github-actions bot added the ready label Sep 8, 2022
@KathrynBaker KathrynBaker added this to the SPRINT_2022_09_08 milestone Sep 8, 2022
@LowriJenkins LowriJenkins self-assigned this Sep 26, 2022
@LowriJenkins
Copy link
Contributor Author

The improper homing behaviour at limits is a result of a check in the motor driver, after brief discussion with tom and freddie, I've raised a discussion issue #7380. Until a decision is reached on this front, I have changed the motor OPI so that the forward home button is disabled when you are at the positive limit, and added a tooltip explaining that you cannot forward home while at the limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants