Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 7277 fix issues with huber #3

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

LowriJenkins
Copy link
Contributor

@LowriJenkins LowriJenkins commented Sep 28, 2022

When homing as long as home is zero (should usually be the case) setpoint is properly reset after home. In some circumstances the old issue can still occur, but only when the home is not at 0. Since this is usually not the case, and the time set aside for this timeboxed issue is over, I've proposed this fix which resolves the problem under normal circumstances.

Issue

ISISComputingGroup/IBEX#7277

To Test

  • Run the system tests
  • While running the emulator verify that after homing using the motor OPI the setpoint returns to 0.

Comment on lines 86 to 87
self.ca.assert_that_pv_is_number(f"{MTR1}.RBV", 0, 1, timeout=30)
self.ca.assert_that_pv_is_number(f"{MTR1}.RBV", 0, 1, timeout=30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion is now duplicate?

Comment on lines 77 to 78
self.ca.assert_that_pv_is_number(f"{MTR1}.RBV", 0, 1, timeout=30)
self.ca.assert_that_pv_is_number(f"{MTR1}.RBV", 0, 1, timeout=30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion is now duplicate?

@Tom-Willemsen Tom-Willemsen merged commit 7749975 into master Oct 3, 2022
@Tom-Willemsen Tom-Willemsen deleted the Ticket_7277_Fix_Issues_with_Huber branch October 3, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants