Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WISH: OPI for WISH Jaws #6033

Closed
kjwoodsISIS opened this issue Jan 8, 2021 · 8 comments
Closed

WISH: OPI for WISH Jaws #6033

kjwoodsISIS opened this issue Jan 8, 2021 · 8 comments
Assignees
Labels

Comments

@kjwoodsISIS
Copy link
Contributor

kjwoodsISIS commented Jan 8, 2021

As a WISH scientist I want to be able to control the 5 sets of jaws in my beamline.

Acceptance Criteria

  1. Using the IBEX client, I can control and setup my 5 sets of jaws
  2. Using the IBEX client, I can select an experiment type which will be used to setup the jaws
  3. Using the IBEX client, I can select an resolution type which will be used to setup the jaws
  4. Using the IBEX client, I can select set the dead-band
  5. The IBEX client provides me with an indication that there is a position error in my jaws (i.e. an LED)
  6. Using genie_python, I can control and setup my 5 sets of jaws
  7. Using genie_python, I can select an experiment type which will be used to setup the jaws
  8. Using genie_python, I can select an resolution type which will be used to setup the jaws

Notes

  1. Check the WISH Instrument wiki.
  2. The jaws are Galil controlled.
  3. GEM & POLARIS have similar OPIs for controlling their jaws.
  4. The OPI must offer functionality equivalent to the existing WISH Jaws VI (located here: C:\LabVIEW Modules\Instruments\WISH\WISH Jaws).
@kjwoodsISIS kjwoodsISIS mentioned this issue Jan 8, 2021
10 tasks
@rerpha rerpha self-assigned this Jun 14, 2021
@rerpha
Copy link
Contributor

rerpha commented Jun 14, 2021

Looks like the experiment type is just preset gaps for each set of jaws - options are:

  • power diffraction
  • single crystal
  • other

Not sure what resolution refers to - looks like there is some sort of averaging going on in the VI?

@KathrynBaker
Copy link
Member

There is averaging in the VI, because of the noise on the encoder readbacks

@daryakoskeroglu
Copy link
Contributor

daryakoskeroglu commented Nov 23, 2021

PR: ISISComputingGroup/ibex_gui#1379
Release Notes PR: #6918

@daryakoskeroglu
Copy link
Contributor

New ticket for creating/connecting missing PVs: #6917

@Adam-Szw
Copy link
Contributor

As I said in the PR review, I'm assuming functionality of the OPI will be reviewed when this is done #6917
I'm merging the OPI itself though

@daryakoskeroglu
Copy link
Contributor

Deleted unnecessary LED and spinners for OPI that were there before in VI version. This OPI is not fully finished as it is waiting for PV to be implemented to populate "Experiment Type" spinner. Adding it to the release to avoid work patching.

@daryakoskeroglu
Copy link
Contributor

daryakoskeroglu commented Jan 11, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants