Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WISH: Connect PVs to WISH Jaws OPI #6917

Closed
1 task done
daryakoskeroglu opened this issue Nov 23, 2021 · 5 comments
Closed
1 task done

WISH: Connect PVs to WISH Jaws OPI #6917

daryakoskeroglu opened this issue Nov 23, 2021 · 5 comments

Comments

@daryakoskeroglu
Copy link
Contributor

daryakoskeroglu commented Nov 23, 2021

As a developer I would like to connect missing PVs on WISH Jaws OPI.

Please check the notes on PR for the OPI: ISISComputingGroup/ibex_gui#1379

The PVs that are need to be connected are:

  1. Experiment Type
    The list needs to be populated (Powder Diffraction, Single Crystal and Other). Possible solution is using the motion setpoints and
    lookup file system,
    Motion Setpoints Wiki: https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Motion-Set-points
    Lookup File System Wiki: https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/ISIS-modules-for-file-handling#readascii
  2. Resolution
  3. Dead Band
  4. Start/Stop and Set buttons

Acceptance Criteria

  • The PVs are connected to relevant widgets

Extra Information

VI for the WISH Jaws is located here: C:\LabVIEW Modules\Instruments\WISH\WISH Jaws

Ticket for creating the OPI: #6033

To check the WISH Instrument wiki: https://github.com/ISISComputingGroup/IBEX/wiki/WISH-Instrument-Details

The jaws are Galil controlled.

GEM & POLARIS have similar OPIs for controlling their jaws.

@JamesKingWork
Copy link
Contributor

Is this connecting the PVs or writing a new IOC to manage the WISH jaws?

@JamesKingWork
Copy link
Contributor

Proposed as the work was expected to be finished in #6033 so probably assumes the same priority as that ticket

@daryakoskeroglu
Copy link
Contributor Author

Is this connecting the PVs or writing a new IOC to manage the WISH jaws?

A bit of both, there is an IOC for Jaws Manager which can be found in C:\Instrument\Apps\EPICS\support\jaws but extra PVs should be implemented in order to finish WISH Jaws manager, for example; a PV which can populate the Experiment Type menu

@rerpha
Copy link
Contributor

rerpha commented Dec 15, 2021

ok, so I think we can probably not worry too much about deadband/motor res as those are things you can set in the table of motors anyway and they probably won't change (?) very often as they're configured using phsyical switches in the galil rack. Deadband is likely already covered by the jaws smoothing that David is looking into.

activity LED can also be removed as it's a SECI VI thing which we don't bother adding in anymore

start/stop/set can also probably be removed as the motion setpoints stuff will do this I think

which means I think this ticket is just to set up motion setpoints for the jaws. I am happy to assist with whoever takes this ticket on as i've just done it for the NIMROD camera, albeit only on one axis.

@rerpha
Copy link
Contributor

rerpha commented Jun 9, 2022

they dont need motion setpoints so closing this ticket - WISH are happy with their jaws currrently

@rerpha rerpha closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants