Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Generator: Make proper use of setInput [Timebox: 2 days] #5811

Closed
DominicOram opened this issue Oct 12, 2020 · 3 comments
Closed

Script Generator: Make proper use of setInput [Timebox: 2 days] #5811

DominicOram opened this issue Oct 12, 2020 · 3 comments
Assignees
Labels

Comments

@DominicOram
Copy link
Contributor

As a user I would like the script generator to be responsive regardless of how many rows I use in my script.

Users found the script generator had some odd bugs when there were many rows (see #5708) where cells were being incorrectly given focus. A hot fix was put in for this which remembers which cells should have focus and correctly reapplies them after it is lost. This solution improves the issue but does not fix the underlying cause. Investigation of a better fix has been written on the ticket.

Acceptance Criteria

@JamesKingWork
Copy link
Contributor

Agreed to pull this in, instead of #6593

@JamesKingWork JamesKingWork self-assigned this Jun 15, 2021
@JamesKingWork JamesKingWork added this to the SPRINT_2021_05_27 milestone Jun 15, 2021
@JamesKingWork
Copy link
Contributor

JamesKingWork commented Jun 23, 2021

The solution has changed from simply making use of setInput and refresh because this simply did not work. Instead, I have implemented a custom refresh or updateActions mechanism which works out what actions need refreshing, adding and removing and then calls the correct methods on the TableViewer (add, remove, replace) to make sure the display is updated correctly.

To test:

  • Add lots of rows very quickly and then try editing and tabbing between cells whilst the script generator validates and calculates an estimated time for all the actions
  • Confirm that general actions still work such as changing script definitions, adding, removing, moving actions up and down, saving and reloading parameters

PRs:

Release notes: #6621

@JamesKingWork
Copy link
Contributor

Check that this also fixes: #5811 and close it if so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants