-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add securuity group and extra parameters #788
Conversation
@@ -2,4 +2,5 @@ record(motor, "$(P)$(M)") { | |||
field(PCOF, "$(PCOF)") | |||
field(HVEL, "$(HVEL)") | |||
field(RDBD, "$(RDBD)") | |||
field(ASG, "WASL0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything including the SPs and home/stop buttons are disabled for me - do I need some sort of access control file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was being stupid, accessSecurity submodule was out of date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can still change OFF, SET, FOFF, CNEN and BDST - probably don't want to do at least the first one?i'm not sure we ever set BDST to anything other than 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do set BSDT on some Galil systems, in fact SANS2D tank might be one of them, but probably won't set it on a mclennan as it has its own backup steps controller parameter. My concern with protecting OFF/SET is don't reflectometer scientists use it - home to neutrons and then define that as zero? This is more thinking of using this more widely, OFF should ideally be protected on a Mclennan as it is a macro, but we are limited in access control levels so we may need to leave it unprotected. The key things to protect here, and the driver for the ticket, was to avoid confusion when electronics/mechatronics group are trying to fault find a mclennan that doesn't move (properly). So they are likely to try and change ERES/MRES/UEIP/ACCL/VELO etc as part of this so they need to be protected to avoid confusion. I feel they are unlikely to try and change OFF in this case, though in an ideal world we would protect it for a mclennan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While looking at this is did however make me realise we need to protect the status update button too ISISComputingGroup/IBEX#7837
Description of work
Add your own description here
To test
See ISISComputingGroup/IBEX#7821
Acceptance criteria
List the acceptance criteria for the PR
Code Review
Functional Tests
..._0n
wheren>1
) run correctlymacLib: macro
to find instances ofmacLib: macro [macro name] is undefined...
Final steps