Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motor: protect status update button during mclennan home/jog #7837

Closed
FreddieAkeroyd opened this issue Jun 6, 2023 · 0 comments
Closed

motor: protect status update button during mclennan home/jog #7837

FreddieAkeroyd opened this issue Jun 6, 2023 · 0 comments
Assignees

Comments

@FreddieAkeroyd
Copy link
Member

FreddieAkeroyd commented Jun 6, 2023

One of the homing modes for the mclennan is to do a jog to a limit, which is done via an SNL homing program. While this is happening the STUP field of the motor record must not be pressed as this aborts the motion. There is a periodic poll of this in db records (https://github.com/ISISComputingGroup/EPICS-motor/blob/master/motorApp/Db/periodic_polling.db) , which we protect from doing such a poll while a jog/home is in progress. I noticed that there is a Status button on the motor details GUI that writes directly to STUP - if somebody was to press this button during a home it would abort the home.

This issue only affects model 1 motor drivers, which we only have the mclennan and linmot. The linmot does not home via a jog, so it is only a mclennan that is affected.

This does not need hardware and can be seen with the maclennan lewis emulator - start a jog and press the status update, the jog aborts

Acceptance criteria

  • the "status" button on the motor details display does not action a STUP when a home/jog is in progress, so a jog is not aborted when it is pressed

Approach

This can probably be done by:

To test

  • You can initially confirm that the button is actioning SAFE_STUP by setting TPRO to 1 on the record and then looking for a processing message printed to IOC console. It is possible to test this with either a mclennan emulator or real hardware, set a jog going and then press Status. Before the change it should abort jog, after change it should not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants