allow device to be put in read-only mode via the GUI #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Willemsen
requested changes
Sep 2, 2019
| @@ -27,7 +29,8 @@ CAENx527ConfigureCreate "hv0", "127.0.0.1" | |||
|
|
|||
| ## Load our record instances | |||
| #dbLoadRecords("db/xxx.db","user=faa59Host") | |||
| CAENx527DbLoadRecords("P=$(MYPVPREFIX)CAEN, ALARM_WHEN_ON=$(ALARM_WHEN_ON=NO_ALARM), ALARM_WHEN_RAMPING=$(ALARM_WHEN_RAMPING=NO_ALARM)") | |||
| $(CAN_WRITE= ) CAENx527DbLoadRecords("P=$(MYPVPREFIX)CAEN, ALARM_WHEN_ON=$(ALARM_WHEN_ON=NO_ALARM), ALARM_WHEN_RAMPING=$(ALARM_WHEN_RAMPING=NO_ALARM), ASG=READONLY") | |||
| $(IFREADONLY= ) CAENx527DbLoadRecords("P=$(MYPVPREFIX)CAEN, ALARM_WHEN_ON=$(ALARM_WHEN_ON=NO_ALARM), ALARM_WHEN_RAMPING=$(ALARM_WHEN_RAMPING=NO_ALARM), ASG=DEFAULT") | |||
There was a problem hiding this comment.
Using this approach we have to duplicate lines in a number of places, this makes the code harder to change in future. How about just passing down the ASG directly from the config (restricted to just READONLY and DEFAULT by the pattern)? This way we don't need to worry about any extra code. I also thing READONLY/DEFAULT are clearer options for a user than #/ (even with an explanation).
| <macros> | ||
| <macro name ="IFREADONLY" pattern="^ |#$" description="Whether device is readonly. Set to # for readonly, default is ' ' (just spacebar), for read and write" /> | ||
| </macros> | ||
| </config_part> |
There was a problem hiding this comment.
This isn't a very user-friendly macro to set, even with the additional description/explanation. As per comment below maybe just pass the ASG directly here as DEFAULT/READONLY as this is clearer.
|
@KathrynBaker would the changes suggested here be acceptable? |
Tom-Willemsen
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Can now set the access security group for all output records to read-only, via a macro.
Ticket
DETMON: Read only option for the HVCAEN IOC #4184
Acceptance criteria
The IOC can be set to read-only mode via the "IFREADONLY" macro, but is not in read-only mode by default.
Code Review
Functional Tests
..._0nwheren>1) run correctlymacLib: macroto find instances ofmacLib: macro [macro name] is undefined...Final steps