Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 3005: Add framework for third IOC #244

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

Rhundas
Copy link

@Rhundas Rhundas commented Mar 15, 2018

Description of work

Created third IOC for KEPCO.

To test

3005

Acceptance criteria

There is a third IOC for KEPCO.


Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@Tom-Willemsen
Copy link
Contributor

All good except KEPCO_03 needs a config.xml file.

You can just reference the file in KEPCO_01's iocBoot directory, to see how this is done look at one of the other drivers that has multiple IOCs (e.g. eurotherm).

@Tom-Willemsen Tom-Willemsen merged commit c26e518 into master Mar 16, 2018
@Tom-Willemsen Tom-Willemsen deleted the Ticket3005_Add_third_KEPCO_IOC branch March 16, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants