Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket2787: Harmonise Galil Motor ioc #202

Merged
merged 5 commits into from
Dec 5, 2017

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Nov 29, 2017

Description of work

See ISISComputingGroup/IBEX#2787

To test

  • Ensure you have pulled and built all three PRs
  • Run the associated upgrade script
  • Ensure that:
    • When adding a galil to a configuration in the GUI it prompts for the new style macros
    • The generic axis.cmd is loaded for each galil axis
    • Galil parameters are autosaved and recovered correctly
    • Galil axes still contribute to the motors moving display and are stopped by stop all
    • The position of a galil in the Table of Motors can be set by MTRCTRL
    • The IOC still works for a simulated motor and a real controller

Notes:

Confirm documentation at
https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Motor-IOCs


Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

Removed accidentally added code
@Tom-Willemsen Tom-Willemsen merged commit 1f23e07 into master Dec 5, 2017
@Tom-Willemsen Tom-Willemsen deleted the Ticket2787_harmonise_motor_ioc branch December 5, 2017 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants