TPG300: fix and re-test switching functions on hardware #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| @@ -48,7 +48,7 @@ getFunctionMacro { | |||
| } | |||
|
|
|||
| setFunction { | |||
| out "SP%(\$1)s,%(\$1\$2).1E,%(\$1\$3).1E,%(\$1\$4)d"; | |||
| out "SP%(\$1)s,%(\$1\$2).1E,%(\$1\$3).1E,%(\$1\$4)d%#/E(\+|-)0(\d)/E\1\2/"; | |||
There was a problem hiding this comment.
Could we add a comment above this line explaining what is going on? Otherwise this is going to confuse future developers, I think...
Tom-Willemsen
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further testing on the TPG300 revealed that it was very picky about the format of its inputs. Specifically, it would not accept any leading zeroes in exponents. Sadly there was no good format converter for this, so it's been accomplished using a regex substring psuedo-converter to just strip off the first 0 after an "E" and a sign in the command (E+0 is valid, E+00 is not, also this section is max 2 digit).
Additionally the UNITS:SP was complaining about being an illegal value, so this has been fixed by defining ZRVL, ONVL, and TWVL.
Ticket
Ticket 7255 - TPG300: fix and re-test switching functions on hardware
Acceptance Criteria