Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPG300: fix and re-test switching functions on hardware #7255

Closed
1 task
Tom-Willemsen opened this issue Jul 26, 2022 · 1 comment
Closed
1 task

TPG300: fix and re-test switching functions on hardware #7255

Tom-Willemsen opened this issue Jul 26, 2022 · 1 comment
Assignees

Comments

@Tom-Willemsen
Copy link
Contributor

Tom-Willemsen commented Jul 26, 2022

Where?

TPG300 IOC

How?

When tested on hardware, sending new switching functions did not work. This should be made to work for RIKEN.

See #7205 (comment) for details including error message - it looks like the command is not quite right as streamdevice is complaining about bad response format.

To test TPG300:

  • Find an appropriate TPG300 to test on (e.g. ask instrument scientists if you can borrow an instrument temporarily)
  • Note what the TPG300 is currently reading before any changes
  • Back up old db/protocol/opi on the instrument
  • Deploy changes to protocol/db/opi
  • Run new TPG300 ioc.
  • Verify that functionality works (e.g. try changing switching functions, verify that readbacks are the same as they were on previous version, etc)
  • Once testing is complete, put IOC back to how it was
  • Once ticket is reviewed, inform scientists that test is complete

Reproducible?

Yes

To Reproduce

  • Run IOC against hardware

Acceptance criteria

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)

@LilithCole
Copy link
Contributor

Tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants